-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Added the Java backend for weathertop2 #7604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,58 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File name has a typo:
WeatheetopTest.java should be WeatherTopTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this file name to remove typo
| - **Detailed Reports**: Generates a Dashboard in client app to inform you of the details such as pass rate for the SDKs, the overall number of tests, and so on. | ||
|
|
||
| ## Getting Started | ||
| ToDO No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide necessary info under Getting Started
| FargateTaskRunner runner = new FargateTaskRunner(); | ||
| String taskRunId = ""; | ||
| if (language.compareTo("java") == 0) { | ||
| String clusteerName = "MyJavaWeathertopCluster"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo; should be clusterName instead of clusteerName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same typo is also at the next 6 else if conditions.
| private static final Region REGION = Region.US_EAST_1; | ||
|
|
||
| // Network config matching Python exactly | ||
| private static final List<String> SUBNETS = List.of( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it required to hard code the subnet and security group config?
| @@ -0,0 +1,58 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this file name to remove typo
This pull request adds Java backend for weathertop
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.