Skip to content

Conversation

@scmacdon
Copy link
Contributor

This pull request adds Java backend for weathertop


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon self-assigned this Sep 29, 2025
@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Tools This issue relates to a custom tooling to streamline development tasks labels Sep 29, 2025
@github-actions github-actions bot removed the Java-v2 This issue relates to the AWS SDK for Java V2 label Sep 29, 2025
@scmacdon scmacdon requested a review from tejasgn1 September 29, 2025 18:57
@@ -0,0 +1,58 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name has a typo:
WeatheetopTest.java should be WeatherTopTest.java

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this file name to remove typo

- **Detailed Reports**: Generates a Dashboard in client app to inform you of the details such as pass rate for the SDKs, the overall number of tests, and so on.

## Getting Started
ToDO No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide necessary info under Getting Started

FargateTaskRunner runner = new FargateTaskRunner();
String taskRunId = "";
if (language.compareTo("java") == 0) {
String clusteerName = "MyJavaWeathertopCluster";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo; should be clusterName instead of clusteerName

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same typo is also at the next 6 else if conditions.

private static final Region REGION = Region.US_EAST_1;

// Network config matching Python exactly
private static final List<String> SUBNETS = List.of(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required to hard code the subnet and security group config?

@@ -0,0 +1,58 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this file name to remove typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools This issue relates to a custom tooling to streamline development tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants