handle all exceptions to avoid system crash (#41)

meshwa19 · Meshwa Savalia · web-flow · commit 4e6211bbf119 · 2022-11-16T16:21:27.000-08:00
Co-authored-by: Meshwa Savalia &lt;meshwas@amazon.com&gt;
diff --git a/src/Amazon.CloudWatch.EMF/Environment/EC2Environment.cs b/src/Amazon.CloudWatch.EMF/Environment/EC2Environment.cs
@@ -57,7 +57,7 @@ public override bool Probe()
             {
                 _token = _resourceFetcher.FetchString(tokenUri, "PUT", tokenRequestHeader);
             }
-            catch (EMFClientException ex)
+            catch (Exception ex)
             {
                 _logger.LogDebug("Failed to get response from: " + tokenUri, ex);
                 return false;
@@ -81,7 +81,7 @@ public override bool Probe()
                 _ec2Metadata = _resourceFetcher.FetchJson<EC2Metadata>(metadataUri, "GET", metadataRequestHeader);
                 return true;
             }
-            catch (EMFClientException ex)
+            catch (Exception ex)
             {
                 _logger.LogDebug("Failed to get response from: " + metadataUri, ex);
             }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public override bool Probe()`
`57`	`57`	`{`
`58`	`58`	`_token = _resourceFetcher.FetchString(tokenUri, "PUT", tokenRequestHeader);`
`59`	`59`	`}`
`60`		`- catch (EMFClientException ex)`
	`60`	`+ catch (Exception ex)`
`61`	`61`	`{`
`62`	`62`	`_logger.LogDebug("Failed to get response from: " + tokenUri, ex);`
`63`	`63`	`return false;`
`@@ -81,7 +81,7 @@ public override bool Probe()`
`81`	`81`	`_ec2Metadata = _resourceFetcher.FetchJson<EC2Metadata>(metadataUri, "GET", metadataRequestHeader);`
`82`	`82`	`return true;`
`83`	`83`	`}`
`84`		`- catch (EMFClientException ex)`
	`84`	`+ catch (Exception ex)`
`85`	`85`	`{`
`86`	`86`	`_logger.LogDebug("Failed to get response from: " + metadataUri, ex);`
`87`	`87`	`}`