Skip to content

Commit b3554fe

Browse files
authored
Fix release workflow
Properly give coordinates to release image
1 parent c3fbb4b commit b3554fe

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

.github/workflows/release.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ env:
2121
AWS_PUBLIC_ECR_REGION: us-east-1
2222
AWS_PRIVATE_ECR_REGION: us-west-2
2323
PUBLIC_REGISTRY: public.ecr.aws
24+
PUBLIC_REPO: aws-observability
2425
STAGING_REGISTRY: 611364707713.dkr.ecr.us-west-2.amazonaws.com
2526
RELEASE_IMAGE_NAME: aws-sigv4-proxy
2627
STAGING_IMAGE_NAME: aws-sigv4-proxy-staging
@@ -70,9 +71,9 @@ jobs:
7071
if: ${{ inputs.dryrunMode == 'true' }}
7172
run: |
7273
docker buildx imagetools create \
73-
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.RELEASE_IMAGE_NAME }}:latest \
74-
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.release-version }} \
75-
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.commit-short-sha }} \
74+
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.PUBLIC_REPO }}/${{ env.RELEASE_IMAGE_NAME }}:latest \
75+
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.PUBLIC_REPO }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.release-version }} \
76+
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.PUBLIC_REPO }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.commit-short-sha }} \
7677
${{ env.STAGING_REGISTRY }}/${{ env.STAGING_IMAGE_NAME }}:${{ steps.release-info.outputs.commit-short-sha }}
7778
--dry-run
7879
@@ -88,9 +89,9 @@ jobs:
8889
if: ${{ inputs.dryrunMode == 'false' }}
8990
run: |
9091
docker buildx imagetools create \
91-
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.RELEASE_IMAGE_NAME }}:latest \
92-
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.release-version }} \
93-
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.commit-short-sha }} \
92+
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.PUBLIC_REPO }}/${{ env.RELEASE_IMAGE_NAME }}:latest \
93+
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.PUBLIC_REPO }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.release-version }} \
94+
--tag ${{ env.PUBLIC_REGISTRY }}/${{ env.PUBLIC_REPO }}/${{ env.RELEASE_IMAGE_NAME }}:${{ steps.release-info.outputs.commit-short-sha }} \
9495
${{ env.STAGING_REGISTRY }}/${{ env.STAGING_IMAGE_NAME }}:${{ steps.release-info.outputs.commit-short-sha }}
9596
9697
- name: Create release

0 commit comments

Comments
 (0)