Skip to content

Commit 900200f

Browse files
committed
Group owners are treated as members
Reinstating original behavior from pre v2.2.x
1 parent 087491f commit 900200f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ SSO Sync will run on any platform that Go can build for. It is available in the
3434
> As of `v2.2.0` multiple query patterns are supported for both Group and User matching, simply separate each query with a `,`. For full sync of groups and/or users specify '*' in the relevant match field.
3535
> User match and group match can now be used in combination with the sync method of groups.
3636
> Nested groups will now be flattened into the top level groups.
37-
> group owners and external users are ignored.
37+
> External users are ignored.
38+
> Group owners are treated as regular group members.
3839
> User details are now cached to reduce the number of api calls and improve execution times on large directories.
3940
4041
## Why?

internal/sync.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,10 +1049,10 @@ func (s *syncGSuite) getGoogleUsersInGroup(group *admin.Group, userCache map[str
10491049
// process the members of the group
10501050
for _, m := range groupMembers {
10511051
log.WithField("email", m.Email).Debug("processing member")
1052-
// Ignore Owners they aren't relevant in Identity Store
1052+
// Ignore Owners aren't relevant in Identity Store
1053+
// so are treated as group members.
10531054
if m.Role == "OWNER" {
1054-
log.WithField("id", m.Email).Debug("ignoring owner roles")
1055-
continue
1055+
log.WithField("id", m.Email).Debug("owner role")
10561056
}
10571057

10581058
// Ignore any external members, since they don't have users

0 commit comments

Comments
 (0)