Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Metric define the Unit it measures? #18

Open
jboynes opened this issue Jun 8, 2018 · 1 comment
Open

Should Metric define the Unit it measures? #18

jboynes opened this issue Jun 8, 2018 · 1 comment

Comments

@jboynes
Copy link
Contributor

jboynes commented Jun 8, 2018

When recording a measurement, the caller has to specify the units of the measurement:

record(Metric label, Number value, Unit unit, Instant time)

This has the potential for different units to be used in different places for the same Metric. How about having the Metric define the canonical unit? That way, application code need not supply it, or if we allow it to, the recorder would then be able to convert it to the canonical unit for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants