Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and fix use of Data, Attributes, and Dimensions. #24

Open
dainstber opened this issue Jun 20, 2018 · 0 comments
Open

Audit and fix use of Data, Attributes, and Dimensions. #24

dainstber opened this issue Jun 20, 2018 · 0 comments

Comments

@dainstber
Copy link
Contributor

Previously we used the term data and dimensions interchangeably. We have since moved to use Attributes when talking about the data within a context and using dimensions to refer too Cloudwatch dimensions. This change was made as part of a larger refactor #19 . In order to unblock the refactor we have merged the PR, despite there being at least one case of the incorrect usage.

We need to audit our use of these terms to ensure consistency.

Metric's Datum are aggregated by dimensions not attributes: [(https://github.com/awslabs/swage/blame/7193ce1285c7502011a12144ef71bdc1dfd3f1c5/metrics-core/src/main/java/software/amazon/swage/metrics/record/cloudwatch/CloudWatchRecorder.java#L353)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant