New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NullContext (MetricsContext) #39

Open

bradboswell opened this issue Oct 30, 2018 · 0 comments

Contributor

bradboswell commented Oct 30, 2018

There's no need for a null MetricsContext as the MetricsContext object shouldn't be doing any work.

The correct way to create a no op handler for metrics is to implement a no op recorder as seen in the NullRecorder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment