Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate S3 resource loader to AWS SDK v2 #55

Closed
maciejwalkowiak opened this issue Feb 12, 2021 · 4 comments
Closed

Migrate S3 resource loader to AWS SDK v2 #55

maciejwalkowiak opened this issue Feb 12, 2021 · 4 comments
Assignees
@eddumelendez
Labels
component: s3 S3 integration related issue
Milestone
3.0.0 M1

Comments

@maciejwalkowiak
Copy link
Contributor

maciejwalkowiak commented Feb 12, 2021 •
edited
Loading

S3 components should be extracted from the core/context module and moved to separate spring-cloud-aws-s3 module. Code should be based on AWS SDK v2.

Things to consider - simplify handling loading files from the different region. Research if client caching has not been done yet in the SDK itself.

XML configuration and @EnableResourceLoader should be dropped.
@maciejwalkowiak maciejwalkowiak added the component: s3 S3 integration related issue label Feb 12, 2021
@maciejwalkowiak maciejwalkowiak added this to the 3.0.x milestone Feb 12, 2021
@maciejwalkowiak maciejwalkowiak self-assigned this Feb 12, 2021
@github-actions github-actions bot added the status: waiting-for-triage Team has not yet looked into this issue label Feb 12, 2021
@maciejwalkowiak maciejwalkowiak removed their assignment Feb 12, 2021
@maciejwalkowiak maciejwalkowiak changed the title Auto-configure S3 resource loader with AWS SDK v2 Migrate S3 resource loader to AWS SDK v2 Feb 12, 2021
@arunkpatra
Copy link
Contributor

@maciejwalkowiak Looks like AWS SDK V2 does not yet support client caching for different regions on the AWS SDK side. Some discussions around it exist, but it doesn't appear to be a top priority for the AWS SDK team.

@maciejwalkowiak maciejwalkowiak removed the status: waiting-for-triage Team has not yet looked into this issue label Feb 23, 2021
@maciejwalkowiak
Copy link
Contributor Author

@eddumelendez is working on S3 integration, perhaps he can share his findings

@eddumelendez
Copy link
Contributor

The following issues have been created as part of the progress on this topic. See aws/aws-sdk-java-v2#2371 aws/aws-sdk-java-v2#2372

@MatejNedic MatejNedic mentioned this issue Dec 30, 2021
Closed
@maciejwalkowiak maciejwalkowiak mentioned this issue Mar 25, 2022
Merged
7 tasks
maciejwalkowiak added a commit that referenced this issue Apr 1, 2022
@maciejwalkowiak
S3 Integration based on AWS SDK v2 (#275)
ac85823 
Re-implement S3 integration with AWS SDK v2:

- auto-configuration for S3 
- cross-region S3 client
- `S3Resource` and integration with `ResourceLoader`
- writeable resource with disk buffering S3 OutputStream and option to provide custom output stream implementation
- object metadata support 
- sample

Fixes #183
Fixes #55
Fixes spring-attic/spring-cloud-aws#104
Fixes spring-attic/spring-cloud-aws#686
@maciejwalkowiak
Copy link
Contributor Author

Fixed in #275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddumelendez eddumelendez

Labels
component: s3 S3 integration related issue
Projects
None yet
Milestone
3.0.0 M1
Development

No branches or pull requests
3 participants
@maciejwalkowiak @eddumelendez @arunkpatra