spring.config.import order is not honored with third-party plugins

[tomek82]

Type: Bug

Component: Secrets Manager

Describe the bug
Continuing from spring-projects/spring-boot#37273

While trying to use a third party Spring Cloud for AWS to load configuration from Secrets Manager and also a local Properties resource I'm observing this:

With application.properties having:
spring.config.import=configtree:config/,classpath:config.properties

I get this order:

OriginTrackedMapPropertySource {name='Config resource 'class path resource [config.properties]' via location 'classpath:config.properties''}
ConfigTreePropertySource {name='Config tree 'xxx\config''}
OriginTrackedMapPropertySource {name='Config resource 'class path resource [application.properties]' via location 'optional:classpath:/''}

Trying:
spring.config.import=classpath:config.properties,configtree:config/

Gives this order:

ConfigTreePropertySource {name='Config tree 'xxx\config''}
OriginTrackedMapPropertySource {name='Config resource 'class path resource [config.properties]' via location 'classpath:config.properties''}
OriginTrackedMapPropertySource {name='Config resource 'class path resource [application.properties]' via location 'optional:classpath:/''}

So far so good and consistent with documentation which says "Several locations can be specified under a single spring.config.import key. Locations will be processed in the order that they are defined, with later imports taking precedence."

However setting:
spring.config.import=aws-secretsmanager:sample/config,classpath:config.properties

Gives me this:

AwsSecretsManagerPropertySource {name='sample/config'}
OriginTrackedMapPropertySource {name='Config resource 'class path resource [config.properties]' via location 'classpath:config.properties''}
OriginTrackedMapPropertySource {name='Config resource 'class path resource [application.properties]' via location 'optional:classpath:/''}

which makes the Plugin take precedence even if declared before the additional file.

Running with Spring Boot 3.1.3 and spring-cloud-starter-aws-secrets-manager-config v2.4.4.

[maciejwalkowiak]

I can't reproduce this issue in Spring Cloud AWS 3.0.2. See #882 (comment)

[MatejNedic]

@maciejwalkowiak can we close this?

[maciejwalkowiak]

Yup