Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set more detailed data type on "timestamp" attribute in SNS message. #932

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Set more detailed data type on "timestamp" attribute in SNS message. #932

merged 1 commit into from
Oct 30, 2023
+2 −1

Conversation

maciejwalkowiak
Copy link
Contributor

Mainly due to keeping backward compatibility with Spring Cloud AWS 2.x

Fixes #791

@maciejwalkowiak
Set more detailed data type on "timestamp" attribute in SNS message.
adfe19b 
Mainly due to keeping backward compatibility with Spring Cloud AWS 2.x

Fixes #791
@github-actions github-actions bot added the component: sns SNS integration related issue label Oct 30, 2023
@maciejwalkowiak maciejwalkowiak mentioned this pull request Oct 30, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@maciejwalkowiak maciejwalkowiak merged commit a2ad6c0 into main Oct 30, 2023
5 of 6 checks passed
@maciejwalkowiak maciejwalkowiak deleted the gh-791 branch October 30, 2023 13:20
@maciejwalkowiak maciejwalkowiak added this to the 3.0.3 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatejNedic MatejNedic Awaiting requested review from MatejNedic MatejNedic is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: sns SNS integration related issue
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

Number MessageAttribute data type for timestamp is incompatible with older versions of Spring Cloud
1 participant
@maciejwalkowiak