From d3e3ba3ae5f2c06c3012ce087385ef6b5f7d1462 Mon Sep 17 00:00:00 2001 From: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Date: Fri, 1 Sep 2023 15:41:18 -0700 Subject: [PATCH] chore: add comment --- halo2_proofs/src/arithmetic.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/halo2_proofs/src/arithmetic.rs b/halo2_proofs/src/arithmetic.rs index 9c7242a36a..59e881f926 100644 --- a/halo2_proofs/src/arithmetic.rs +++ b/halo2_proofs/src/arithmetic.rs @@ -60,6 +60,7 @@ fn multiexp_serial(coeffs: &[C::Scalar], bases: &[C], acc: &mut tmp as usize } + // Ideally `segments` should be calculated from the max number of bits among all scalars. But this requires a scan of all scalars, so we don't implement it for now. let segments = (C::Scalar::NUM_BITS as usize + c - 1) / c; // this can be optimized