File tree Expand file tree Collapse file tree 4 files changed +57
-2
lines changed Expand file tree Collapse file tree 4 files changed +57
-2
lines changed Original file line number Diff line number Diff line change @@ -17,7 +17,7 @@ export const rawColumnToInternalColumn = (
17
17
column : ColumnOptionsRaw
18
18
) : Column => ( {
19
19
name : column . name ,
20
- title : column . title || column . name ,
20
+ title : column . title ?? column . name ,
21
21
...objIfExists ( 'color' , column . color as COLOR ) ,
22
22
...objIfExists ( 'maxLen' , column . maxLen ) ,
23
23
...objIfExists ( 'minLen' , column . minLen ) ,
Original file line number Diff line number Diff line change @@ -73,7 +73,7 @@ export const createColumFromComputedColumn = (
73
73
column : ComputedColumn
74
74
) : Column => ( {
75
75
name : column . name ,
76
- title : column . title || column . name ,
76
+ title : column . title ?? column . name ,
77
77
...objIfExists ( 'color' , column . color as COLOR ) ,
78
78
...objIfExists ( 'maxLen' , column . maxLen ) ,
79
79
...objIfExists ( 'minLen' , column . minLen ) ,
Original file line number Diff line number Diff line change 1
1
// Jest Snapshot v1, https://goo.gl/fbAQLP
2
2
3
+ exports [` Testing Title Of Column Empty string title means blank title 1` ] = `
4
+ "┌───┬───────────────────────────────────┬───────────────────────────┐
5
+ │[37m [0m[01m [0m │[37m [0m[01m [0m │[37m [0m[01mOther two should be blank[0m │
6
+ ├───┼───────────────────────────────────┼───────────────────────────┤
7
+ │[37m [0m[34m2[0m │[37m [0m[34m This row is blue[0m │[37m [0m[34m 10.212 [0m │
8
+ │[37m [0m[31m3[0m │[37m [0m[31mI would like some red wine please[0m │[37m [0m[31m 10.212 [0m │
9
+ └───┴───────────────────────────────────┴───────────────────────────┘"
10
+ ` ;
11
+
3
12
exports [` Testing Title Of Column title is used in table printing 1` ] = `
4
13
"┌──────────────────────┬───────────────────────────────────┬────────────────────────┐
5
14
│[37m [0m[01mRed Left Align Index[0m │[37m [0m[01m Right Align Text[0m │[37m [0m[01mBig Green Value Center[0m │
Original file line number Diff line number Diff line change @@ -47,6 +47,52 @@ describe('Testing Title Of Column', () => {
47
47
48
48
console . log ( returned ) ;
49
49
expect ( returned ) . toMatchSnapshot ( ) ;
50
+ } ) ;
51
+
52
+ it ( 'Empty string title means blank title' , ( ) => {
53
+ // Create a table
54
+ const p = new Table ( {
55
+ columns : [
56
+ {
57
+ name : 'red_left_align_index' ,
58
+ alignment : 'left' ,
59
+ title : '' ,
60
+ } ,
61
+ {
62
+ name : 'right_align_text' ,
63
+ alignment : 'right' ,
64
+ title : '' ,
65
+ } ,
66
+ {
67
+ name : 'green_value_center' ,
68
+ alignment : 'center' ,
69
+ title : 'Other two should be blank' ,
70
+ } ,
71
+ ] ,
72
+ } ) ;
73
+
74
+ // add rows with color
75
+ p . addRow (
76
+ {
77
+ red_left_align_index : 2 ,
78
+ right_align_text : 'This row is blue' ,
79
+ green_value_center : 10.212 ,
80
+ } ,
81
+ { color : 'blue' }
82
+ ) ;
83
+ p . addRow (
84
+ {
85
+ red_left_align_index : 3 ,
86
+ right_align_text : 'I would like some red wine please' ,
87
+ green_value_center : 10.212 ,
88
+ } ,
89
+ { color : 'red' }
90
+ ) ;
91
+
92
+ // print
93
+ const returned = renderTable ( p . table ) ;
94
+
50
95
console . log ( returned ) ;
96
+ expect ( returned ) . toMatchSnapshot ( ) ;
51
97
} ) ;
52
98
} ) ;
You can’t perform that action at this time.
0 commit comments