adding fromItems all around

Author: pfmmfp

src/Psl/Collection/Map.php

@@ -66,6 +66,19 @@ public static function fromArray(array $elements): Map
         return new self($elements);
     }
 
+    /**
+     * @template Tsk of array-key
+     * @template Tsv
+     *
+     * @param array<Tsk, Tsv> $items
+     *
+     * @return Map<Tsk, Tsv>
+     */
+    public static function fromItems(iterable $items): Map
+    {
+        return self::fromArray(iterator_to_array($items));
+    }
+
     /**
      * Returns the first value in the current collection.
      *

src/Psl/Collection/MutableMap.php

@@ -66,6 +66,19 @@ public static function fromArray(array $elements): MutableMap
         return new self($elements);
     }
 
+    /**
+     * @template Tsk of array-key
+     * @template Tsv
+     *
+     * @param array<Tsk, Tsv> $items
+     *
+     * @return MutableMap<Tsk, Tsv>
+     */
+    public static function fromItems(iterable $items): MutableMap
+    {
+        return self::fromArray(iterator_to_array($items));
+    }
+
     /**
      * Returns the first value in the current collection.
      *

src/Psl/Collection/MutableSet.php

@@ -71,6 +71,20 @@ public static function fromArray(array $elements): MutableSet
         return new self($elements);
     }
 
+    /**
+     * Create a set from the given iterable, using the values of the iterable as the set values.
+     *
+     * @template Ts of array-key
+     *
+     * @param iterable<Ts> $items
+     *
+     * @return MutableSet<Ts>
+     */
+    public static function fromItems(iterable $items): MutableSet
+    {
+        return self::fromArray(iterator_to_array($items));
+    }
+
     /**
      * Create a set from the given $elements array, using the keys of the array as the set values.
      *

src/Psl/Collection/Set.php

@@ -72,6 +72,22 @@ public static function fromArray(array $elements): Set
         return new self($elements);
     }
 
+    /**
+     * Create a set from the given items, using the keys of the array as the set values.
+     *
+     * @template Ts of array-key
+     *
+     * @param iterable<Ts, mixed> $items
+     *
+     * @return Set<Ts>
+     *
+     * @pure
+     */
+    public static function fromItems(iterable $items): Set
+    {
+        return self::fromArray(iterator_to_array($items));
+    }
+
     /**
      * Create a set from the given $elements array, using the keys of the array as the set values.
      *

src/Psl/Collection/Vector.php

@@ -69,6 +69,20 @@ public static function fromArray(array $elements): Vector
         return new self($elements);
     }
 
+    /**
+     * Create a vector from the given $items iterable.
+     *
+     * @template Ts
+     *
+     * @param iterable<Ts> $items
+     *
+     * @return Vector<Ts>
+     */
+    public static function fromItems(iterable $items): Vector
+    {
+        return self::fromArray(iterator_to_array($items));
+    }
+
     /**
      * Returns the first value in the current `Vector`.
      *

tests/unit/Collection/MapTest.php

@@ -19,6 +19,19 @@ final class MapTest extends AbstractMapTest
      */
     protected string $vectorClass = Vector::class;
 
+    public function testFromItems(): void
+    {
+        $map = Map::fromItems([
+            'foo' => 'bar',
+            'bar' => 'baz',
+            'baz' => 'qux',
+        ]);
+
+        static::assertSame('bar', $map->at('foo'));
+        static::assertSame('baz', $map->at('bar'));
+        static::assertSame('qux', $map->at('baz'));
+    }
+
     /**
      * @template     Tk of array-key
      * @template     Tv

tests/unit/Collection/MutableMapTest.php

@@ -153,7 +153,7 @@ public function testArrayAccess(): void
 
         static::assertTrue(isset($map['foo']));
         static::assertSame('1', $map['foo']);
-        
+
         unset($map['foo']);
         static::assertFalse(isset($map['foo']));
 
@@ -235,6 +235,18 @@ public function testOffsetGetThrowsForInvalidOffsetType(): void
         $map[false];
     }
 
+    public function testFromItems(): void {
+        $map = MutableMap::fromItems([
+            'foo' => 'bar',
+            'bar' => 'baz',
+            'baz' => 'qux',
+        ]);
+
+        static::assertSame('bar', $map->at('foo'));
+        static::assertSame('baz', $map->at('bar'));
+        static::assertSame('qux', $map->at('baz'));
+    }
+
     /**
      * @template     Tk of array-key
      * @template     Tv

tests/unit/Collection/MutableSetTest.php

@@ -109,7 +109,7 @@ public function testArrayAccess(): void
 
         static::assertTrue(isset($set['foo']));
         static::assertSame('foo', $set['foo']);
-        
+
         unset($set['foo']);
         static::assertFalse(isset($set['foo']));
 
@@ -191,6 +191,12 @@ public function testOffsetGetThrowsForInvalidOffsetType(): void
         $set[false];
     }
 
+    public function testFromItems(): void
+    {
+        $set = MutableSet::fromItems(['a', 'b', 'b', 'c']);
+        static::assertSame(['a' => 'a', 'b' => 'b', 'c' => 'c'], $set->toArray());
+    }
+
     /**
      * @template T of array-key
      *

tests/unit/Collection/MutableVectorTest.php

@@ -236,7 +236,6 @@ public function testFromItems(): void
         static::assertSame([1, 2, 3], $vector->toArray());
     }
 
-
     /**
      * @template     T
      *

tests/unit/Collection/SetTest.php

@@ -15,6 +15,18 @@ final class SetTest extends AbstractSetTest
      */
     protected string $setClass = Set::class;
 
+    public function testFromItems(): void {
+        $set = Set::fromItems([
+            'foo',
+            'bar',
+            'baz',
+        ]);
+
+        static::assertTrue($set->contains('foo'));
+        static::assertTrue($set->contains('bar'));
+        static::assertTrue($set->contains('baz'));
+    }
+
     /**
      * @template T of array-key
      *

tests/unit/Collection/VectorTest.php

@@ -15,6 +15,12 @@ final class VectorTest extends AbstractVectorTest
      */
     protected string $vectorClass = Vector::class;
 
+    public function testFromItems(): void
+    {
+        $vector = Vector::fromItems([1, 2, 3]);
+        static::assertSame([1, 2, 3], $vector->toArray());
+    }
+
     /**
      * @template T
      *