fix(type): Positive int has a broken exception path (#459)

veewee · web-flow · commit f11403168713 · 2024-04-04T18:46:17.000+01:00
diff --git a/src/Psl/Type/Internal/PositiveIntType.php b/src/Psl/Type/Internal/PositiveIntType.php
@@ -58,10 +58,7 @@ public function coerce(mixed $value): int
                 return $int;
             }
 
-            // Exceptional case "000" -(trim)-> "", but we treat it as 0
-            if ('' === $trimmed && '' !== $str) {
-                CoercionException::withValue($value, $this->toString());
-            }
+            throw CoercionException::withValue($value, $this->toString());
         }
 
         if (is_float($value)) {

Original file line number	Diff line number	Diff line change
`@@ -58,10 +58,7 @@ public function coerce(mixed $value): int`
`58`	`58`	`return $int;`
`59`	`59`	`}`
`60`	`60`
`61`		`- // Exceptional case "000" -(trim)-> "", but we treat it as 0`
`62`		`- if ('' === $trimmed && '' !== $str) {`
`63`		`- CoercionException::withValue($value, $this->toString());`
`64`		`- }`
	`61`	`+ throw CoercionException::withValue($value, $this->toString());`
`65`	`62`	`}`
`66`	`63`
`67`	`64`	`if (is_float($value)) {`