chore: fix static analysis (#474)

Signed-off-by: azjezz <azjezz@protonmail.com>

Author: azjezz

docs/component/str-byte.md

@@ -30,7 +30,7 @@
 - [contains_ci](./../../src/Psl/Str/Byte/contains_ci.php#L21)
 - [ends_with](./../../src/Psl/Str/Byte/ends_with.php#L12)
 - [ends_with_ci](./../../src/Psl/Str/Byte/ends_with_ci.php#L14)
-- [length](./../../src/Psl/Str/Byte/length.php#L14)
+- [length](./../../src/Psl/Str/Byte/length.php#L16)
 - [lowercase](./../../src/Psl/Str/Byte/lowercase.php#L14)
 - [ord](./../../src/Psl/Str/Byte/ord.php#L12)
 - [pad_left](./../../src/Psl/Str/Byte/pad_left.php#L24)

docs/component/str-grapheme.md

@@ -24,7 +24,7 @@
 - [contains_ci](./../../src/Psl/Str/Grapheme/contains_ci.php#L22)
 - [ends_with](./../../src/Psl/Str/Grapheme/ends_with.php#L16)
 - [ends_with_ci](./../../src/Psl/Str/Grapheme/ends_with_ci.php#L16)
-- [length](./../../src/Psl/Str/Grapheme/length.php#L18)
+- [length](./../../src/Psl/Str/Grapheme/length.php#L20)
 - [range](./../../src/Psl/Str/Grapheme/range.php#L43)
 - [reverse](./../../src/Psl/Str/Grapheme/reverse.php#L16)
 - [search](./../../src/Psl/Str/Grapheme/search.php#L27)

src/Psl/Iter/Iterator.php

@@ -164,14 +164,14 @@ public function rewind(): void
     /**
      * Seek to the given position.
      *
-     * @param int<0, max> $offset
+     * @param int<0, max> $position
      *
      * @throws Exception\OutOfBoundsException If $position is out-of-bounds.
      */
-    public function seek(int $offset): void
+    public function seek(int $position): void
     {
-        if ($offset <= $this->position) {
-            $this->position = $offset;
+        if ($position <= $this->position) {
+            $this->position = $position;
             return;
         }
 
@@ -184,16 +184,16 @@ public function seek(int $offset): void
                     $this->generator = null;
                     throw new Exception\OutOfBoundsException('Position is out-of-bounds.');
                 }
-            } while ($this->position < $offset);
+            } while ($this->position < $position);
 
             return;
         }
 
-        if ($offset >= $this->count()) {
+        if ($position >= $this->count()) {
             throw new Exception\OutOfBoundsException('Position is out-of-bounds.');
         }
 
-        $this->position = $offset;
+        $this->position = $position;
     }
 
     /**

src/Psl/Str/Byte/compare.php

@@ -11,8 +11,8 @@
  * Returns < 0 if `$string1` is less than `$string2`, > 0 if `$string1` is
  * greater than `$string2`, and 0 if they are equal.
  *
- * @param int|null $length number of characters to use in the comparison,
- *                         or null to compare the whole string
+ * @param int<0, max>|null $length number of characters to use in the comparison,
+ *                                 or null to compare the whole string
  *
  * @pure
  */

src/Psl/Str/Byte/compare_ci.php

@@ -13,8 +13,8 @@
  *
  * @pure
  *
- * @param int|null $length number of characters to use in the comparison,
- *                         or null to compare the whole string
+ * @param int<0, max>|null $length number of characters to use in the comparison,
+ *                                 or null to compare the whole string
  */
 function compare_ci(string $string, string $other, ?int $length = null): int
 {

src/Psl/Str/Byte/length.php

@@ -9,6 +9,8 @@
 /**
  * Returns the length of the given string, i.e. the number of bytes.
  *
+ * @return int<0, max>
+ *
  * @pure
  */
 function length(string $string): int

src/Psl/Str/Byte/strip_suffix.php

@@ -35,7 +35,9 @@ function strip_suffix(string $string, string $suffix): string
     /**
      * $string_length is greater than $suffix_length, so the result is always int<0, max>.
      *
-     * @psalm-suppress ArgumentTypeCoercion
+     * @var int<0, max> $length
      */
-    return slice($string, 0, $string_length - $suffix_length);
+    $length = $string_length - $suffix_length;
+
+    return slice($string, 0, $length);
 }

src/Psl/Str/Grapheme/length.php

@@ -11,9 +11,11 @@
 /**
  * Returns the length of the given string in grapheme units.
  *
- * @pure
- *
  * @throws Exception\InvalidArgumentException If $string is not made of grapheme clusters.
+ *
+ * @return int<0, max>
+ *
+ * @pure
  */
 function length(string $string): int
 {

src/Psl/Str/Grapheme/strip_suffix.php

@@ -39,7 +39,9 @@ function strip_suffix(string $string, string $suffix): string
     /**
      * $string_length is greater than $suffix_length, so the result is always int<0, max>.
      *
-     * @psalm-suppress ArgumentTypeCoercion
+     * @var int<0, max> $length
      */
-    return slice($string, 0, $string_length - $suffix_length);
+    $length = $string_length - $suffix_length;
+
+    return slice($string, 0, $length);
 }

src/Psl/Str/length.php

@@ -20,9 +20,9 @@
  *      Str\length('تونس')
  *      => Int(4)
  *
- * @pure
- *
  * @return int<0, max>
+ *
+ * @pure
  */
 function length(string $string, Encoding $encoding = Encoding::Utf8): int
 {