From d92edcf8fc0ea70f47ba7c6f320870eed622b281 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 3 Oct 2022 03:34:06 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- .../pygments/lexers/_php_builtins.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py b/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py index 168cb446..5764cf42 100644 --- a/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py +++ b/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py @@ -4725,7 +4725,26 @@ def get_php_functions(): def get_php_references(): download = urlretrieve(PHP_MANUAL_URL) with tarfile.open(download[0]) as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(tar) yield from glob.glob("%s%s" % (PHP_MANUAL_DIR, PHP_REFERENCE_GLOB)) os.remove(download[0]) From 09c67f554633fceb9028bed2dae6c8c095c2ca9b Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 23:15:35 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- .../Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py b/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py index 5764cf42..3c0936c6 100644 --- a/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py +++ b/env/lib/python3.8/site-packages/Pygments-2.8.1-py3.8.egg/pygments/lexers/_php_builtins.py @@ -4741,7 +4741,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(tar)