Skip to content

[bundleXpcf] packageignoreinstall.txt is not processed when no pkgdeps file is provided #28

@jim-bcom

Description

@jim-bcom

HOW TO REPRODUCE

  • take an XPCF-based project which has a non-empty packageignoreinstall.txt at its root
  • if it has a packagedependencies.txt at its root, rename it to something different, e.g. foo.txt
  • run remaken bundleXpcf --recurse ... without passing the --pkgdeps argument so that no pkgdeps can be processed

EXPECTED BEHAVIOR

  • as the the direct dependencies file is not named packagedependencies.txt, the bundle() step is ignored
  • as the --recurse option is set, it will process every packagedependencies.txt found in each remaken dependencies listed in the XPCF config XML file by bundling every listed deps except for the one listed in packageignoreinstall.txt.

OBSERVED BEHAVIOR

  • bundle() step is indeed skipped due to missing pkgdeps file
  • but since it's done by throwing an exception as the file is not found, it also skips the processing of packageignoreinstall.txt, preventing the list of ignored deps to be populated.
  • thus, when bundling recursively the deps, all deps found in encountered remaken-type deps `packadependencies.txt' are installed.

This leads to a different behavior regarding ignored transitive deps whether a pkgdeps file is provided or not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    Status

    To do

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions