Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new screenshot for Basis with Hero image introduced in Backdrop 1.30 #6862

Open
olafgrabienski opened this issue Mar 4, 2025 · 4 comments · May be fixed by backdrop/backdrop#5029
Open

Comments

@olafgrabienski
Copy link

I'd like to suggest that we show the new wavy hero SVG image in the screenshot.png of the Basis theme.

The SVG hero image was introduced in Backdrop 1.30.0, issue #6752. There was a similar case when we changed the screenshot after introducing the Home page cards, see #5621.

Current screenshot:

New screenshot proposal:

The image dimensions are 600 x 416px. On the Theme admin page, the screenshot is scaled down to a width of 294px.

@indigoxela
Copy link
Member

@olafgrabienski counting the "thumbs up" on the issue description - I guess there's consensus. 😉 We're just waiting for a PR.

@olafgrabienski
Copy link
Author

@indigoxela It seems I need some help in this particular case. I use to make pull requests via the Github interface, as described in https://backdropcms.org/news/creating-pull-requests-against-core-the-easy-noob-way. It's not clear to me, how I can replace a (binary) file in this scenario. If this isn't possible or rather complicated using the Github interface, I'd be happy if someone else could take over.

@indigoxela
Copy link
Member

indigoxela commented Mar 8, 2025

I use to make pull requests via the Github interface...

@olafgrabienski I'm afraid, I'm the wrong person to ask such a question. I never work with the GH code interface, always only with commandline.

But it seems like @izmeez helps out with a PR. 👍 Looks good!

@olafgrabienski
Copy link
Author

never work with the GH code interface, always only with commandline.

I see, no problem!

But it seems like @izmeez helps out with a PR.

Great, thanks @izmeez for taking over. I've had a look at the sandbox of the PR: the appearance page with the screenshot looks perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants