Merge pull request #208 from balancer/minor-fixes-and-refactors

Minor fixes and refactors

Author: brunoguerios

.changeset/dull-starfishes-learn.md

@@ -0,0 +1,5 @@
+---
+"@balancer/sdk": patch
+---
+
+Minor refactors and lint fixes

examples/addLiquidity.ts

@@ -70,7 +70,7 @@ const addLiquidity = async () => {
         slippage,
         sender: userAccount,
         recipient: userAccount,
-        chainId
+        chainId,
     });
 
     console.log('\nWith slippage applied:');

examples/removeLiquidity.ts

@@ -74,7 +74,7 @@ const removeLiquidity = async () => {
         slippage,
         sender: userAccount,
         recipient: userAccount,
-        chainId
+        chainId,
     });
 
     console.log('\nWith slippage applied:');

package.json

@@ -24,7 +24,6 @@
         "test:ci": "vitest run",
         "changeset": "changeset",
         "changeset:release": "pnpm build && changeset publish",
-        "anvil": "anvil --fork-url $(. ./.env && echo $ETHEREUM_RPC_URL)",
         "example": "npx tsx ./examples/executeExample.ts"
     },
     "dependencies": {

src/data/providers/balancer-api/modules/nested-pool-state/index.ts

@@ -1,7 +1,7 @@
 import { BalancerApiClient } from '../../client';
 import { NestedPool, NestedPoolState } from '../../../../../entities';
 import { MinimalToken } from '../../../../types';
-import { Address, Hex, PoolType } from '../../../../../types';
+import { Address, Hex } from '../../../../../types';
 import { mapPoolType } from '@/utils/poolTypeMapper';
 
 type PoolGetPool = {
@@ -230,15 +230,4 @@ export class NestedPools {
             mainTokens,
         } as NestedPoolState;
     };
-
-    mapPoolType = (type: string): PoolType => {
-        switch (type) {
-            case 'WEIGHTED':
-                return PoolType.Weighted;
-            case 'COMPOSABLE_STABLE':
-                return PoolType.ComposableStable;
-            default:
-                throw new Error(`Unsupported pool type ${type}`);
-        }
-    };
 }

src/entities/addLiquidity/types.ts

@@ -65,7 +65,7 @@ type AddLiquidityBaseCall = {
     slippage: Slippage;
     sender: Address;
     recipient: Address;
-    chainId: number
+    chainId: number;
 };
 
 export type AddLiquidityComposableStableCall = AddLiquidityBaseCall &

src/entities/removeLiquidity/removeLiquidityV2/composableStable/removeLiquidityComposableStable.ts

@@ -1,11 +1,7 @@
 import { encodeFunctionData } from 'viem';
 import { Token } from '../../../token';
 import { TokenAmount } from '../../../tokenAmount';
-import {
-    VAULT,
-    MAX_UINT256,
-    ZERO_ADDRESS,
-} from '../../../../utils/constants';
+import { VAULT, MAX_UINT256, ZERO_ADDRESS } from '../../../../utils/constants';
 import { vaultV2Abi } from '../../../../abi';
 import { parseRemoveLiquidityArgs } from '../../../utils/parseRemoveLiquidityArgs';
 import {

src/entities/removeLiquidity/removeLiquidityV2/weighted/removeLiquidityWeighted.ts

@@ -2,11 +2,7 @@ import { encodeFunctionData } from 'viem';
 import { Token } from '../../../token';
 import { TokenAmount } from '../../../tokenAmount';
 import { WeightedEncoder } from '../../../encoders/weighted';
-import {
-    VAULT,
-    MAX_UINT256,
-    ZERO_ADDRESS,
-} from '../../../../utils/constants';
+import { VAULT, MAX_UINT256, ZERO_ADDRESS } from '../../../../utils/constants';
 import { vaultV2Abi } from '../../../../abi';
 import { parseRemoveLiquidityArgs } from '../../../utils/parseRemoveLiquidityArgs';
 import {

src/utils/poolTypeMapper.ts

@@ -13,7 +13,11 @@ export const mapPoolType = (type: string): PoolType => {
     const supportedPoolTypes = Object.keys(poolTypeMap);
 
     if (!supportedPoolTypes.includes(type)) {
-        throw new Error(`Unsupported pool type ${type}`);
+        throw new Error(
+            `Unsupported pool type ${type} - supported types are ${supportedPoolTypes.join(
+                ', ',
+            )}`,
+        );
     }
 
     return poolTypeMap[type];

test/lib/utils/addLiquidityHelper.ts

@@ -52,7 +52,7 @@ async function sdkAddLiquidity({
         slippage,
         sender: testAddress,
         recipient: testAddress,
-        chainId: addLiquidityInput.chainId
+        chainId: addLiquidityInput.chainId,
     });
 
     return {

test/lib/utils/removeLiquidityHelper.ts

@@ -44,7 +44,7 @@ export const sdkRemoveLiquidity = async ({
         slippage,
         sender: testAddress,
         recipient: testAddress,
-        chainId: removeLiquidityInput.chainId
+        chainId: removeLiquidityInput.chainId,
     });
 
     return {
@@ -188,7 +188,7 @@ export function assertRemoveLiquidityUnbalanced(
         removeLiquidityBuildOutput,
         false,
         slippage,
-        chainId
+        chainId,
     );
 
     assertTokenDeltas(
@@ -263,7 +263,7 @@ export function assertRemoveLiquiditySingleToken(
         removeLiquidityBuildOutput,
         true,
         slippage,
-        chainId
+        chainId,
     );
 
     assertTokenDeltas(
@@ -320,7 +320,7 @@ export function assertRemoveLiquidityProportional(
         removeLiquidityBuildOutput,
         true,
         slippage,
-        chainId
+        chainId,
     );
 
     assertTokenDeltas(