[PoC] Implement quoteAndRevert in the router #1063
Closed
+159
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaobrunoah
changed the title
|
Since #1073 was abandoned, this PR is not viable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements quoteAndRevert in the router, so batched operations revert individually and one query does not affect the other, if they're executed in a batch transaction.
This PR is in draft mode because adds 1.5kb to the current router.
Also, some mutation tests were removed because we the hook state is reverted after the query is executed, so it's not possible to check the sender address anymore.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
Closes #1062