Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test testPermitBatchAndCall to check addLiquidity output #635

Open
joaobrunoah opened this issue Jun 7, 2024 · 0 comments
Open

Fix test testPermitBatchAndCall to check addLiquidity output #635

joaobrunoah opened this issue Jun 7, 2024 · 0 comments
Assignees

Comments

@joaobrunoah
Copy link
Contributor

joaobrunoah commented Jun 7, 2024

The forge test testPermitBatchAndCall doesn't check if addLiquidity was successful, so a combination of operations in which addLiquidity and removeLiquidity returns 0 would pass the test.

To make it more robust, we can check the addLiquidity event and make sure it returned the expected amount of BPTs and spent the expected amount of amountsIn.

@joaobrunoah joaobrunoah self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant