Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider preventing vault state read when we're outside the pause window #648

Open
jubeira opened this issue Jun 12, 2024 · 1 comment
Open
Milestone

Comments

@jubeira
Copy link
Contributor

jubeira commented Jun 12, 2024

If we first check the timestamp, we don't need to read the vault state here: https://github.com/balancer/balancer-v3-monorepo/pull/644/files#diff-b757055907971a411ff87a80666c784ed52f185cd2cf892abbd46bfe9f1cd38dR157

@jubeira jubeira added this to the Cleanup milestone Jun 12, 2024
@EndymionJkb
Copy link
Collaborator

EndymionJkb commented Jul 3, 2024

I'm not sure what you mean here. _isVaultPaused is an &&, so if we're past the timestamp it will short-circuit and not check the vault state anyway (i.e., it already does check the timestamp first to avoid unnecessarily reading the VaultState).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants