Merge pull request #14 from bamlab/tpucci-patch-2

tpucci · web-flow · commit 6867b3e298f6 · 2018-04-09T15:31:53.000+02:00
fix(android): Fix Picker for Android when initialising it with null v…
diff --git a/src/withPickerValues/PickerModal.js b/src/withPickerValues/PickerModal.js
@@ -30,7 +30,7 @@ class PickerModal extends PureComponent<PropsType> {
       values.unshift({ value: '', label: placeholder });
     } else {
       // Fix for issue: https://github.com/facebook/react-native/issues/15556
-      values.push({ value: '', label: '' });
+      values.unshift({ value: '', label: '' });
     }
     const picker = (
       <Picker onValueChange={this.onValueChange} selectedValue={value} prompt={placeholder}>

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class PickerModal extends PureComponent<PropsType> {`
`30`	`30`	`values.unshift({ value: '', label: placeholder });`
`31`	`31`	`} else {`
`32`	`32`	`// Fix for issue: https://github.com/facebook/react-native/issues/15556`
`33`		`- values.push({ value: '', label: '' });`
	`33`	`+ values.unshift({ value: '', label: '' });`
`34`	`34`	`}`
`35`	`35`	`const picker = (`
`36`	`36`	`<Picker onValueChange={this.onValueChange} selectedValue={value} prompt={placeholder}>`