Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to call Helmet.renderStatic() to avoid a memory leak? #141

Open
bherila opened this issue Jun 27, 2017 · 3 comments
Open

Do we need to call Helmet.renderStatic() to avoid a memory leak? #141

bherila opened this issue Jun 27, 2017 · 3 comments

Comments

@bherila
Copy link
Contributor

bherila commented Jun 27, 2017

It says in the README for Helmet under "Server usage":

Because this component keeps track of mounted instances, you have to make sure to call renderStatic on server, or you'll get a memory leak.

Do we need to do this somewhere in Vortigern?

Thanks,
Ben

@bherila
Copy link
Contributor Author

bherila commented Jun 27, 2017

Turns out .rewind() is deprecated, per

https://github.com/nfl/react-helmet/blob/07851a670f2342161c128558f8e17cbffbd61dfd/CHANGELOG.md

we should change Helmet.rewind() to Helmet.renderStatic()

@TriStarGod
Copy link

Great catch. I'm still reading about Helmet. Not sure how to request admin to update master. I also think script clean should be renamed cleanbuild in package.json. I used yarn to run my stuff and entered "yarn clean" which incorrectly clean my source files.

@bherila
Copy link
Contributor Author

bherila commented Jul 3, 2017

@TriStarGod yarn run clean should work, it works for me anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants