Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normalization of paths for macOS #9

Open
rmehner opened this issue Feb 28, 2019 · 1 comment
Open

Remove normalization of paths for macOS #9

rmehner opened this issue Feb 28, 2019 · 1 comment

Comments

@rmehner
Copy link

rmehner commented Feb 28, 2019

👋

Gatsby started using this project in a recent release and unfortunately it lead to a new bug (gatsbyjs/gatsby#12005 (comment)) I've dug a bit deeper and found that it is caused by this line:

if (process.platform === 'darwin') fsPathNormalized = fsPathNormalized.normalize('NFD')

HFS+ is no longer the default file system for newer Macs and with High Sierra they even upgraded HFS+ systems to APFS if the computer is using a SSD.

APFS seems to not store things with NFD anymore, but if we try to normalize the path, glob will return an empty array for the normalized path. If we remove that line, everything works as expected.

Unfortunately I don't have any old mac with HFS anymore, so I can't test it out right now, but what do you think the best way going forward would be?

There's also #8 lingering around, which I have yet to try.

Thanks for reading this and have a great day :)

@caseyWebb
Copy link

Fixed in fork Profiscience/true-case-path, published in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants