feat(connectors): allow skipping OAuth with Esc key #217

Paveltarno · 2026-02-09T14:25:33Z

Note

Description

This PR adds the ability to skip individual OAuth connector authorizations during the connectors push flow by pressing the Esc key. Previously, users had to wait for authorization to complete or timeout, or kill the entire process. Now when authorizing multiple connectors, users can skip specific connectors without interrupting the entire push operation. Skipped connectors are tracked and reported separately in the summary output.

Related Issue

Part of #184 (connectors feature implementation)

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (no functional changes)
Other (please describe):

Changes Made

Added runOAuthFlowWithSkip() function to handle OAuth flows with Esc key skip capability
Introduced OAuthFlowStatus type extending ConnectorOAuthStatus with "SKIPPED" state
Implemented temporary process.exit override to intercept Esc/Ctrl+C key presses during OAuth flow
Updated printSummary() to track and display skipped connectors as warnings
Replaced runTask() with direct spinner() usage for more control over exit handling
Added polling constants (POLL_INTERVAL_MS, POLL_TIMEOUT_MS) for OAuth status checks
Enhanced spinner messages to indicate "Esc to skip" functionality
Added comprehensive JSDoc comment explaining the process.exit override mechanism

Testing

I have tested these changes locally
I have added/updated tests as needed
All tests pass (npm test)

Checklist

My code follows the project's style guidelines
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (if applicable)
My changes generate no new warnings
I have updated AGENTS.md if I made architectural changes

Additional Notes

Technical implementation: Clack's block() function (used by spinner()) puts stdin in raw mode where Esc/Ctrl+C triggers process.exit(0) directly instead of emitting SIGINT. To implement skip functionality, we temporarily override process.exit during the OAuth flow to set a skipped flag instead of killing the process. The override is restored in a finally block to ensure normal exit behavior is preserved after each connector's authorization attempt.

Review fixes: Added inline comment documenting the process.exit override, wrapped OAuth flow in try/catch/finally for better error handling.

_{🤖 Generated by Claude | 2026-02-12 22:15 UTC}

github-actions · 2026-02-09T14:26:04Z

🚀 Package Preview Available!

Install this PR's preview build with npm:

npm i @base44-preview/cli@0.0.31-pr.217.a8a828c

Prefer not to change any import paths? Install using npm alias so your code still imports base44:

npm i "base44@npm:@base44-preview/cli@0.0.31-pr.217.a8a828c"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "base44": "npm:@base44-preview/cli@0.0.31-pr.217.a8a828c"
  }
}

📦 Preview Package: @base44-preview/cli@0.0.31-pr.217.a8a828c
🔗 View this commit on GitHub

_{Preview published to npm registry — try new features instantly!}

kfirstri

I commented this in the parent PR #189

the entire pWaitFor should not be in the core/ folder.. and in this PR there's now also spinners and more stuff which core/ packages should not be familiar with.

claude · 2026-02-12T13:48:21Z

README check ran. 5 issue(s) found and applied: Added missing eject command, added missing connectors push command, updated deploy description to match code, updated logout description to match code, updated whoami description to match code. README.md has been updated in this branch (commit ready to push).

claude · 2026-02-12T13:58:35Z

README check ran. 10 issues found:

Missing eject command (uncommented)
Missing connectors push command
3-10. Updated command descriptions to match code

README.md has been updated in this branch.

claude · 2026-02-12T14:00:15Z

README check ran. 3 issues found and applied: (1) Added missing eject command, (2) Added missing connectors push command, (3) Updated command descriptions to match source code exactly. README.md has been updated in this branch.

claude · 2026-02-12T14:04:08Z

README check ran. 3 issue(s) found and applied: (1) Added missing eject command, (2) Updated logout description to match code, (3) Added missing connectors push command. README.md has been updated in this branch.

src/cli/commands/connectors/push.ts

kfirstri · 2026-02-12T15:01:30Z

src/cli/commands/connectors/push.ts

+        interval: POLL_INTERVAL_MS,
+        timeout: POLL_TIMEOUT_MS,
+      },
+    ).catch((err) => {


why not use try/catch/finally

kfirstri

small changes

Add connector resource module supporting 12 OAuth providers: googlecalendar, googledrive, gmail, googlesheets, googledocs, googleslides, slack, notion, salesforce, hubspot, linkedin, tiktok. - Zod discriminated union schema with type discriminator per provider - JSDoc links to official OAuth scope documentation for each provider - JSONC file reading with validation (filename must match type field) - API response schemas for upstream connector state - Unit tests with fixtures for valid, invalid, and mismatched connectors Part of: #184 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(connectors): implement push logic for syncing connectors Add pushConnectors function that: - Syncs all local connectors via /sync endpoint - Removes upstream-only connectors not in local config - Returns typed results (synced, removed, needs_oauth, error) Includes unit tests covering all scenarios. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(connectors): add OAuth flow handling with browser redirect and polling (#192) * feat(connectors): add OAuth flow handling with browser redirect and polling Add runOAuthFlow function that: - Opens OAuth redirect URL in browser - Polls getOAuthStatus until ACTIVE or FAILED - Returns PENDING on timeout (5 minutes) Uses p-wait-for TimeoutError for robust timeout detection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * connectors: base44 connectors push (#194) * final connector work sofi 1 * scopes --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Change provider field from closed enum to flexible union that accepts both known providers (googlecalendar, notion, slack, etc.) and any arbitrary provider string. This enables users to configure custom OAuth providers without waiting for first-class Base44 support. Schema changes: - Add GenericConnectorSchema for arbitrary provider types - Update ConnectorResourceSchema to union of specific + generic schemas - Update IntegrationTypeSchema to accept known enum OR any non-empty string - Only reject empty strings Test coverage: - Verify known providers continue to work - Verify arbitrary providers are accepted - Verify empty strings are rejected - All 137 tests passing Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Override process.exit temporarily during the spinner to intercept Ctrl+C/Escape (which clack's block() converts to process.exit(0)), letting users skip individual connector authorizations instead of killing the entire process. Adds SKIPPED status to the summary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

claude · 2026-02-12T16:21:36Z

README check ran. 6 issue(s) found: 1) Missing eject command (currently commented out), 2) Missing connectors push command, 3) Outdated descriptions for create, deploy, link, logout, whoami, agents pull, agents push, and entities push. Manual update required - edit permission was not granted during automated check.

kfirstri added this to CLI Development Feb 9, 2026

github-project-automation bot moved this to Backlog in CLI Development Feb 9, 2026

dor-chaouat moved this from Backlog to In progress in CLI Development Feb 9, 2026

Paveltarno force-pushed the pavelta-connectors-1 branch from 7bfb43f to 7b418ac Compare February 10, 2026 11:59

Paveltarno force-pushed the pavelta-connectors-skip-oauth branch from e304a12 to 3d50451 Compare February 10, 2026 15:18

base44 deleted a comment from claude bot Feb 10, 2026

kfirstri requested changes Feb 11, 2026

View reviewed changes

github-project-automation bot moved this from In progress to Ready in CLI Development Feb 11, 2026

Paveltarno force-pushed the pavelta-connectors-1 branch 2 times, most recently from 3fc2e0c to ec69f63 Compare February 12, 2026 12:04

Base automatically changed from pavelta-connectors-1 to main February 12, 2026 13:27

Paveltarno force-pushed the pavelta-connectors-skip-oauth branch from 99b7274 to 21ed8d3 Compare February 12, 2026 13:46

Paveltarno force-pushed the pavelta-connectors-skip-oauth branch from c04ffd5 to bdb1198 Compare February 12, 2026 13:57

base44 deleted a comment from claude bot Feb 12, 2026

Paveltarno force-pushed the pavelta-connectors-skip-oauth branch from bdb1198 to bd6d0a4 Compare February 12, 2026 14:02

kfirstri reviewed Feb 12, 2026

View reviewed changes

src/cli/commands/connectors/push.ts Show resolved Hide resolved

kfirstri reviewed Feb 12, 2026

View reviewed changes

kfirstri moved this from Ready to In progress in CLI Development Feb 12, 2026

Paveltarno requested a review from kfirstri February 12, 2026 16:19

Paveltarno and others added 5 commits February 12, 2026 18:20

review fixes

30a3e45

Paveltarno and others added 3 commits February 12, 2026 18:20

fix

f069647

lint

fb7f917

review fixes: add process.exit override comment, use try/catch/finally

53c7c7d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Paveltarno force-pushed the pavelta-connectors-skip-oauth branch from 066105c to 53c7c7d Compare February 12, 2026 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connectors): allow skipping OAuth with Esc key #217

feat(connectors): allow skipping OAuth with Esc key #217

Uh oh!

Paveltarno commented Feb 9, 2026 •

edited by claude bot

Loading

Uh oh!

github-actions bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

kfirstri left a comment

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

Uh oh!

kfirstri Feb 12, 2026

Uh oh!

kfirstri left a comment

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(connectors): allow skipping OAuth with Esc key #217

Are you sure you want to change the base?

feat(connectors): allow skipping OAuth with Esc key #217

Uh oh!

Conversation

Paveltarno commented Feb 9, 2026 • edited by claude bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Changes Made

Testing

Checklist

Additional Notes

Uh oh!

github-actions bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Package Preview Available!

Uh oh!

kfirstri left a comment

Choose a reason for hiding this comment

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

Uh oh!

kfirstri Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

kfirstri left a comment

Choose a reason for hiding this comment

Uh oh!

claude bot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Paveltarno commented Feb 9, 2026 •

edited by claude bot

Loading

github-actions bot commented Feb 9, 2026 •

edited

Loading