linting improvements

Author: netroy

.eslintrc

@@ -20,11 +20,15 @@
     "max-statements": ["error", 23],
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/interface-name-prefix": "off",
-    "@typescript-eslint/member-delimiter-style": ["error", {
-      "multiline": { "delimiter": "none" }
-    }],
+    "@typescript-eslint/member-delimiter-style": [
+      "error",
+      {
+        "multiline": { "delimiter": "none" }
+      }
+    ],
     "@typescript-eslint/no-unused-vars": "error",
     "@typescript-eslint/consistent-type-definitions": ["error", "type"],
+    "@typescript-eslint/consistent-type-imports": "error"
   },
   "overrides": [
     {

.vscode/settings.json

@@ -0,0 +1,10 @@
+{
+  "editor.formatOnSave": true,
+  "editor.codeActionsOnSave": {
+    "source.fixAll": true,
+    "source.fixAll.eslint": true
+  },
+  "[typescript]": {
+    "editor.defaultFormatter": "rvest.vs-code-prettier-eslint"
+  }
+}

lib/detector.ts

@@ -1,4 +1,5 @@
-import { typeHandlers, imageType } from './types/index'
+import type { imageType } from './types/index'
+import { typeHandlers } from './types/index'
 
 const keys = Object.keys(typeHandlers) as imageType[]
 

lib/index.ts

@@ -1,9 +1,10 @@
 import * as fs from 'fs'
 import * as path from 'path'
 import Queue from 'queue'
-import { typeHandlers, imageType } from './types/index'
+import type { imageType } from './types/index'
+import { typeHandlers } from './types/index'
 import { detector } from './detector'
-import { ISizeCalculationResult } from './types/interface'
+import type { ISizeCalculationResult } from './types/interface'
 
 type CallbackFn = (e: Error | null, r?: ISizeCalculationResult) => void
 

lib/types/bmp.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { toUTF8String, readInt32LE, readUInt32LE } from './utils'
 
 export const BMP: IImage = {

lib/types/cur.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { ICO } from './ico'
 import { readUInt16LE } from './utils'
 

lib/types/dds.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { readUInt32LE } from './utils'
 
 export const DDS: IImage = {

lib/types/gif.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { toUTF8String, readUInt16LE } from './utils'
 
 const gifRegexp = /^GIF8[79]a/

lib/types/icns.ts

@@ -1,4 +1,4 @@
-import { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface'
 import { toUTF8String, readUInt32BE } from './utils'
 
 /**

lib/types/ico.ts

@@ -1,4 +1,4 @@
-import { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface'
 import { readUInt16LE } from './utils'
 
 const TYPE_ICON = 1

lib/types/j2c.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { toHexString, readUInt32BE } from './utils'
 
 export const J2C: IImage = {

lib/types/jp2.ts

@@ -1,4 +1,4 @@
-import { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface'
 import { toHexString, toUTF8String, readUInt32BE, readUInt16BE } from './utils'
 
 const BoxTypes = {

lib/types/jpg.ts

@@ -3,7 +3,7 @@
 // with a maximum size of 4096 bytes. so if the SOF marker is outside
 // if this range we can't detect the file size correctly.
 
-import { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface'
 import { readUInt, readUInt16BE, toHexString } from './utils'
 
 const EXIF_MARKER = '45786966'

lib/types/ktx.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { toUTF8String, readUInt32LE } from './utils'
 
 export const KTX: IImage = {

lib/types/png.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { toUTF8String, readUInt32BE } from './utils'
 
 const pngSignature = 'PNG\r\n\x1a\n'

lib/types/pnm.ts

@@ -1,4 +1,4 @@
-import { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface'
 import { toUTF8String } from './utils'
 
 const PNMTypes = {

lib/types/psd.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { toUTF8String, readUInt32BE } from './utils'
 
 export const PSD: IImage = {

lib/types/svg.ts

@@ -1,4 +1,4 @@
-import { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface'
 import { toUTF8String } from './utils'
 
 type IAttributes = {

lib/types/tga.ts

@@ -1,4 +1,4 @@
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { readUInt16LE } from './utils'
 
 export const TGA: IImage = {

lib/types/tiff.ts

@@ -1,7 +1,7 @@
 // based on http://www.compix.com/fileformattif.htm
 // TO-DO: support big-endian as well
 import * as fs from 'fs'
-import { IImage } from './interface'
+import type { IImage } from './interface'
 import { readUInt, toHexString, toUTF8String } from './utils'
 
 // Read IFD (image-file-directory) into a buffer

lib/types/webp.ts

@@ -1,5 +1,5 @@
 // based on https://developers.google.com/speed/webp/docs/riff_container
-import { IImage, ISize } from './interface'
+import type { IImage, ISize } from './interface'
 import { toHexString, toUTF8String, readInt16LE, readUInt24LE } from './utils'
 
 function calculateExtended(input: Uint8Array): ISize {

specs/valid.spec.ts

@@ -4,7 +4,7 @@ import { extname, resolve } from 'path'
 import { openSync, readSync } from 'fs'
 import { imageSize } from '../lib'
 import { detector } from '../lib/detector'
-import { ISizeCalculationResult } from '../lib/types/interface'
+import type { ISizeCalculationResult } from '../lib/types/interface'
 
 const bufferSize = 8192