Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_disable_starlark_host_transitions will break Bazel skylib in Bazel 7.0 #418

Open
keertk opened this issue Dec 16, 2022 · 2 comments

Comments

@keertk
Copy link
Member

keertk commented Dec 16, 2022

Incompatible flag --incompatible_disable_starlark_host_transitions will be enabled by default in the next major release (Bazel 7.0), thus breaking Bazel skylib. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#17032.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@tetromino
Copy link
Collaborator

bazel-skylib does not use cfg = "host"; the error comes from the gazelle plugin's dependency on rules_go.

We'd need to update our rules_go dep to 0.38.0 or newer.

@tetromino
Copy link
Collaborator

... and we'd also need for rules_pkg to update its rules_license dep to be compatible with --incompatible_disable_starlark_host_transitions. But fortunately that's build dep only - it won't affect users of bazel-skylib releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants