Fix JacocoInstrumentationProcessor move() failure on some filesystems #25273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursive directory traversal has no guarantees around files&directories that are added after the traversal has started, in particular it's unsafe to - move `.class` away to `.class.uninstrumented` - create new `.class` with same name - continue recursive traversal As it is allowed by POSIX `readdir()` to visit newly-created `.class` again https://pubs.opengroup.org/onlinepubs/007904875/functions/readdir_r.html > If a file is removed from or added to the directory after the most recent call to opendir() or rewinddir(), whether a subsequent call to readdir_r() returns an entry for that file is unspecified. And second visit will attempt to instrument already instrumented `.class`, but actually fail on the `move()` step as destination already exists. This does reliably happen on buildbarn remote FUSE workers when running `bazel coverage` for JVM targets Fixes bazelbuild#25272
github-actions
bot
added
team-Rules-Java
|
Haven't yet run the patch on repro case, but will do |
|
Needs a java_tools bump somewhere, |
|
Looks like the flow is: change code here -> release java_tools -> release rules_java -> update rules_java. Or maybe override java_toolchain to point to manually built |
|
This probably also fixes #24838. |
|
Validated that the fix works via dmivankov/bug_reports@04cb53e |
c-mita
added
awaiting-PR-merge
|
Thank you for making fixes to improve compatibility with Buildbarn’s FUSE file system. Really appreciated! |
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursive directory traversal has no guarantees around files&directories that are added after the traversal has started, in particular it's unsafe to
.classaway to.class.uninstrumented.classwith same nameAs it is allowed by POSIX
readdir()to visit newly-created.classagain https://pubs.opengroup.org/onlinepubs/007904875/functions/readdir_r.htmlAnd second visit will attempt to instrument already instrumented
.class, but actually fail on themove()step as destination already exists.This does reliably happen on buildbarn remote FUSE workers when running
bazel coveragefor JVM targetsFixes #25272