Release - December 2017 - Target RC date: 2017-12-01 - name: 0.9.0 #3773

damienmg · 2017-09-20T11:53:18Z

Release tracking bug for December 2017:

Target cut should be 1st of December (first business day of December)
Name: 0.9.0

/cc @dslomov. You are planned to be the RM for this one but as I said I could exchange would fit my schedule better.

damienmg · 2017-11-30T07:24:33Z

So the nightly seems pretty broken right now: https://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/bazel/job/nightly/Downstream_projects/

rules_docker is broken by 0.8.0 CI: rules_docker failing on macOS #4173
rules_go has failing tests which is probably the cause for buildifier and bazel-watcher (CI: bazel-watcher failing on macOS #4172) failure
Intellij is also broken

I guess we won't be able to get a clean release tomorrow. I won't be able to follow up much as I am traveling today.

@philwo, current buildcop, FYI

@dslomov @ulfjack I guess this is case for having the build cop be the release manager too?

philwo · 2017-11-30T08:32:20Z

What is a build cop? Is that something different than the sheriff?

damienmg · 2017-11-30T09:11:10Z

Sorry for the confusion. It is the same. I just tend to use build cop on the issue tracker because I find the term is clearer that sheriff on what the sheriff does.

…

On Thu, Nov 30, 2017, 9:32 AM Philipp Wollermann ***@***.***> wrote: What is a build cop? Is that something different than the sheriff? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3773 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjHf7RgTWgBHBEpxmHTrWOyIpCcOQKxks5s7mgdgaJpZM4PdwG-> .

dslomov · 2017-11-30T09:26:54Z

let's stabilize before Monday, I think that's doable - and let's cut on Monday if we can On Thu, 30 Nov 2017, 10:11 Damien Martin-Guillerez, < notifications@github.com> wrote:

…

Sorry for the confusion. It is the same. I just tend to use build cop on the issue tracker because I find the term is clearer that sheriff on what the sheriff does. On Thu, Nov 30, 2017, 9:32 AM Philipp Wollermann ***@***.*** > wrote: > What is a build cop? Is that something different than the sheriff? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <#3773 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/ADjHf7RgTWgBHBEpxmHTrWOyIpCcOQKxks5s7mgdgaJpZM4PdwG- > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3773 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AExrX2dSXTGx4SwiziRPcxUzyKHpOEhLks5s7nE3gaJpZM4PdwG-> .

philwo · 2017-11-30T10:06:41Z

Ok! I’ll have a look at the open breakages and coordinate with Dmitry once I’m in the office in a few minutes.

philwo · 2017-11-30T12:31:08Z

The bazel-tests failure in process_wrapper-test should be fixed in the next nightly thanks to 89ec374

philwo · 2017-11-30T20:04:21Z

Is there anything that I can do to help get this sorted out?

dslomov · 2017-11-30T20:55:07Z

See this update: #4173 (comment)
@iirina will investigate and we'll make a decision based on her fix.

aj-michael · 2017-12-01T16:52:15Z

#4208 is breaking Android, and we don't have a fix yet.

damienmg · 2017-12-04T09:21:30Z

So adding @iirina this week sheriff.

Status: candidate not possible, there was no nightly due to the disconnected mac slaves. The nightly is now running, I will update the status once it has run.

damienmg · 2017-12-04T09:59:17Z

So the nightly failed in bootstrapping on a python error on gflags...

damienmg · 2017-12-04T10:02:10Z

It happens only on Ubuntu 14.04, list of changes in the nightly:

Properly enforce one version for android_robolectric_test targets by (commit: 3c5581d)
Remove unused adb_jobs flag. (commit: bda9ada)
Match upstream python-gflags-3.1.0 imports (fixes pkg_tar fails to import gflags when using py3 #3816) (commit: fb15f0f)
Update python-gflags to version 3.1.1 (commit: 8fd0f4a)
Windows: Don't leak any handles from Bazel client to Bazel server (commit: 9c97bf9)
Avoid NPEs when providers are not found in JavaInfo. (commit: 49008a3)
Windows: Expose find_vc_path and find_msvc_tool function (commit: ff12a22)
Prevent git filegroup from choking on gitk temporary files. (commit: 062da5c)
Make AndroidSdkProvider.verifyPresence throw. (commit: 6a5669a)
Move IDL constant out of AndroidSemantics (commit: c69068a)
Remove duplicated method from AndroidBinary. (commit: dec0329)
Add user and system execution time to provide total CPU execution time (commit: 26bc282)

So fb15f0f and 8fd0f4a as likely culprits

damienmg · 2017-12-04T11:12:57Z

So I got more time to investigate failures of the latest nightly that ran fully before the mac issues:

rules_go (and buildifier and buildtools) are failing likely due to 337f19c: i'll probably rollback and rollforward with fixing rules_go.
intellij is broken due to --incompatible_disallow_set_constructor disappearing coming from /cc @vladmos

The other failure seems to be rules_docker which should be fixed.

jin · 2017-12-04T22:26:30Z

#4208 is also fixed.

laszlocsomor · 2017-12-05T13:15:40Z

laszlocsomor · 2017-12-05T14:34:22Z

Release notes edits:

removed "RELNOTES: None for Blaze users." entry
removed both (duplicate) relnotes coming from a7a9d56 and its rollback 944d4f7
removed duplicate relnotes from a rollback-commit 0dd27ab and its roll-forward 1e3d568
with advice from @vladmos , removed the relnotes from c5e9a47 in favor of 9bb93ee
removed relnotes from 7e5c4af because it has no observable effect on Bazel

laszlocsomor · 2017-12-05T14:36:58Z

Created 0.9.0rc1:

(...)/release.sh create 0.9.0 ddd5ac16aeffa6c4693c348f73e7365240b1abc
Created 0.9.0rc1 on branch release-0.9.0.

petemounce · 2017-12-05T15:00:08Z

curl https://releases.bazel.build/0.9.0/rc1/index.html

<Error>
<Code>NoSuchKey</Code>
<Message>The specified key does not exist.</Message>
</Error>

laszlocsomor · 2017-12-05T15:09:43Z

Not yet pushed.

petemounce · 2017-12-05T15:14:33Z

Ah, ok.

laszlocsomor · 2017-12-06T09:47:32Z

RC is now pushed:

announcement: https://groups.google.com/forum/#!msg/bazel-discuss/js7iR3f9oew/PNbQBpK0BAAJ
binaries: https://releases.bazel.build/0.9.0/rc1/index.html

damienmg · 2017-12-06T14:11:39Z

FTR the global test for 0.9 is there: https://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/bazel/job/release/491/Downstream_projects/

laszlocsomor · 2017-12-06T14:18:15Z

Need to cherrypick for RC2:

2cf560f (fixes CI, bazel-nightly: TF, TF serving, and bazel-tests are failing #4233)
a2d2615 (@aj-michael said: "This fixes a bug introduced in e5fb5f0")
68c577a

Maybe need to cherrypick (waiting for answer):

~~e4eb23f~~: update: @haxorz confirmed that no cherrypick is necessary
~~67566e5~~: update: @lberki confirmed that this is unimportant and no cherrypick is necessary

laszlocsomor · 2017-12-08T13:29:57Z

Need to cherrypick for rc3:

commit 766ba8a

laszlocsomor · 2017-12-08T14:30:32Z

Creating rc3. I'll update the thread when it's pushed.

  $ (...)/release.sh create 0.9.0 \
          ddd5ac16aeffa6c4693c348f73e7365240b1abc \
          2cf560f83922e6df9626ba3ee063c1caf6797548 \
          a2d2615362c65be98629b39ce39754a325ed1c42 \
          68c577afc2fb33b5e66b820bcc9043fed1071456 \
          766ba8adc4487f17ebfc081aeba6f34b18b53d6c
(...)
Created 0.9.0rc3 on branch release-0.9.0.

  $ (...)/release.sh push
(...)
To github.com:bazelbuild/bazel
   8e1f466e3..b1903dcb0  refs/notes/cherrypick -> refs/notes/cherrypick

laszlocsomor · 2017-12-08T16:26:00Z

Pushed.
Post-submit test results: https://ci.bazel.io/job/bazel/job/release/559/Downstream_projects/

laszlocsomor · 2017-12-08T16:29:51Z

The only post-submit failures are:

protobuf: already failing with 0.8.1, see CI, protobuf: failing with bazel 0.9.0 rc2 #4250
TF serving: same as CI, TF serving: failing with bazel 0.9.0 rc2 #4252

petemounce · 2017-12-09T01:31:47Z

https://chocolatey.org/packages/bazel/0.9.0-rc3 is up.

laszlocsomor · 2017-12-11T09:05:37Z

Great, thanks Peter!

laszlocsomor · 2017-12-11T16:36:30Z

@davidstanke and @ola-rozenfeld requested cherrypick for RC4:

a22d0e9

laszlocsomor · 2017-12-11T16:59:24Z

Created new RC and initiated push:

  $ (...)/release.sh create 0.9.0 \
          ddd5ac16aeffa6c4693c348f73e7365240b1abc \
          2cf560f83922e6df9626ba3ee063c1caf6797548 \
          a2d2615362c65be98629b39ce39754a325ed1c42 \
          68c577afc2fb33b5e66b820bcc9043fed1071456 \
          766ba8adc4487f17ebfc081aeba6f34b18b53d6c \
          a22d0e9c14e58b29d81f5a83bdcc6e5fce52eafe

I needed to resolve a merge conflict:

diff --cc src/test/shell/bazel/remote_execution_test.sh
index 601bcc9e0,5eadb1d1a..000000000
--- a/src/test/shell/bazel/remote_execution_test.sh
+++ b/src/test/shell/bazel/remote_execution_test.sh
@@@ -29,11 -30,10 +30,15 @@@ function set_up() 
    while [ $attempts -le 5 ]; do
      (( attempts++ ))
      worker_port=$(pick_random_unused_tcp_port) || fail "no port found"
++<<<<<<< HEAD
 +    hazelcast_port=$(pick_random_unused_tcp_port) || fail "no port found"
 +    "${bazel_data}/src/tools/remote_worker/remote_worker" \
++=======
+     "${bazel_data}/src/tools/remote/worker" \
++>>>>>>> a22d0e9c1... Fix: uploading artifacts of failed actions to remote cache stopped working.
          --work_path="${work_path}" \
          --listen_port=${worker_port} \
-         --hazelcast_standalone_listen_port=${hazelcast_port} \
+         --cas_path=${cas_path} \
          --pid_file="${pid_file}" >& $TEST_log &
      local wait_seconds=0
      until [ -s "${pid_file}" ] || [ "$wait_seconds" -eq 15 ]; do

Per advice from @ola-rozenfeld , I resolved it as:

   while [ $attempts -le 5 ]; do
      (( attempts++ ))
      worker_port=$(pick_random_unused_tcp_port) || fail "no port found"
      "${bazel_data}/src/tools/remote_worker/remote_worker" \
            --work_path="${work_path}" \
            --listen_port=${worker_port} \
            --cas_path=${cas_path} \
            --pid_file="${pid_file}" >& $TEST_log &

laszlocsomor · 2017-12-12T09:35:25Z

Cherrypick request for RC5:

CL 178732031 to fix bug 70522059 ("Bazel generates duplicated actions if java_common.compile is called twice")

iirina · 2017-12-12T13:15:44Z

CL 178732031 to fix bug 70522059 ("Bazel generates duplicated actions if java_common.compile is called twice")

Fix commit is 03964c8

laszlocsomor · 2017-12-12T14:24:46Z

@iirina : Thanks!

RC4 push failed, and I messed up my local git clone, so I'm recreating RC4 from scratch. (I'm updating the release guide for future Bazel release managers; I'm pretty sure I know what I'm doing.)

  $ (...)/release.sh create 0.9.0 \
          ddd5ac16aeffa6c4693c348f73e7365240b1abc \
          2cf560f83922e6df9626ba3ee063c1caf6797548 \
          a2d2615362c65be98629b39ce39754a325ed1c42 \
          68c577afc2fb33b5e66b820bcc9043fed1071456 \
          766ba8adc4487f17ebfc081aeba6f34b18b53d6c \
          a22d0e9c14e58b29d81f5a83bdcc6e5fce52eafe \
          03964c8ccb20d673add76c7f37245e837c3899b6

laszlocsomor · 2017-12-12T14:37:13Z

Pushed: https://releases.bazel.build/0.9.0/rc4/index.html

laszlocsomor · 2017-12-12T15:40:29Z

Unfortunately, the cherrypick a22d0e9 needs the commit that added the //src/tools/remote package, namely 2f3d7df. I'll create RC5 with that in it. /cc @ola-rozenfeld

https://ci.bazel.io/job/Global/job/bazel-tests/403/consoleFull

[node=linux-x86_64] ERROR: /home/ci/workspace/Global/bazel-tests-node=linux-x86_64/src/test/shell/bazel/BUILD:423:1: no such package 'src/tools/remote': BUILD file not found on package path and referenced by '//src/test/shell/bazel:remote_execution_rest_test'

laszlocsomor · 2017-12-12T15:44:17Z

Ha! Including 2f3d7df got rid of the merge conflict from a22d0e9 in RC4.

Created RC5 and initiated push. CI started building: https://ci.bazel.io/job/bazel/job/release/603/

  $ (...)/release.sh create 0.9.0 ddd5ac16aeffa6c4693c348f73e7365240b1abc 2cf560f83922e6df9626ba3ee063c1caf6797548 a2d2615362c65be98629b39ce39754a325ed1c42 68c577afc2fb33b5e66b820bcc9043fed1071456  766ba8adc4487f17ebfc081aeba6f34b18b53d6c 2f3d7df5750ec7f3ac293c92c31d2969af2dd1cf a22d0e9c14e58b29d81f5a83bdcc6e5fce52eafe 03964c8ccb20d673add76c7f37245e837c3899b6                                                                 
remote: Counting objects: 3443, done        
remote: Finding sources: 100% (28/28)           
remote: Total 28 (delta 11), reused 28 (delta 11)        
From sso://bazel/bazel
 * branch                master     -> FETCH_HEAD
Creating new release branch release-0.9.0 for release 0.9.0
Switched to and reset branch 'release-0.9.0'
Applying cherry-picks
  Cherry-picking 2cf560f83922e6df9626ba3ee063c1caf6797548
  Cherry-picking a2d2615362c65be98629b39ce39754a325ed1c42
  Cherry-picking 68c577afc2fb33b5e66b820bcc9043fed1071456
  Cherry-picking 766ba8adc4487f17ebfc081aeba6f34b18b53d6c
  Cherry-picking 2f3d7df5750ec7f3ac293c92c31d2969af2dd1cf
  Cherry-picking a22d0e9c14e58b29d81f5a83bdcc6e5fce52eafe
  Cherry-picking 03964c8ccb20d673add76c7f37245e837c3899b6
Creating release notes
Created 0.9.0rc5 on branch release-0.9.0.

  $ (...)/release.sh push
...
To github.com:bazelbuild/bazel
   243833b91..ac65b44c5  refs/notes/cherrypick -> refs/notes/cherrypick

ola-rozenfeld · 2017-12-12T17:53:15Z

It should not need that. The rest_test can reference the worker from the old path. Note how the /src/tools/remote is not a new package, I just moved /src/tools/remote_worker to /src/tools/remote. If you do cherrypick the move, be mindful to change the references in remote_execution_test and remote_execution_rest test appropriately (and the BUILD file as well).

…

On Tue, Dec 12, 2017 at 10:44 AM, László Csomor ***@***.***> wrote: Ha! Including 2f3d7df <2f3d7df> got rid of the merge conflict from a22d0e9 <a22d0e9> in RC4. Created RC5 and initiated push. CI started building: https://ci.bazel.io/job/bazel/job/release/603/ $ (...)/release.sh create 0.9.0 ddd5ac1 2cf560f a2d2615 68c577a 766ba8a 2f3d7df a22d0e9 03964c8 remote: Counting objects: 3443, done remote: Finding sources: 100% (28/28) remote: Total 28 (delta 11), reused 28 (delta 11) From sso://bazel/bazel * branch master -> FETCH_HEAD Creating new release branch release-0.9.0 for release 0.9.0 Switched to and reset branch 'release-0.9.0' Applying cherry-picks Cherry-picking 2cf560f Cherry-picking a2d2615 Cherry-picking 68c577a Cherry-picking 766ba8a Cherry-picking 2f3d7df Cherry-picking a22d0e9 Cherry-picking 03964c8 Creating release notes Created 0.9.0rc5 on branch release-0.9.0. $ (...)/release.sh push ... To github.com:bazelbuild/bazel 243833b..ac65b44 refs/notes/cherrypick -> refs/notes/cherrypick — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3773 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYoKuLRIwS69RDhF_SdOOjA_R6lxuFtgks5s_p9rgaJpZM4PdwG-> .

laszlocsomor · 2017-12-13T09:03:16Z

OK, I created RC6 without 2f3d7df and with manual edits while cherrypicking a22d0e9 in order to resolve the merge conflict (same way as earlier) and to change references of src/tools/remote{,/remote} to src/tools/remote_worker{,/remote_worker}:

  $ (...)/release.sh create 0.9.0 ddd5ac16aeffa6c4693c348f73e7365240b1abc 2cf560f83922e6df9626ba3ee063c1caf6797548 a2d2615362c65be98629b39ce39754a325ed1c42 68c577afc2fb33b5e66b820bcc9043fed1071456  766ba8adc4487f17ebfc081aeba6f34b18b53d6c a22d0e9c14e58b29d81f5a83bdcc6e5fce52eafe 03964c8ccb20d673add76c7f37245e837c3899b6

petemounce · 2017-12-13T16:22:41Z

RCs 4-6 inclusive are available from chocolatey.

laszlocsomor · 2017-12-13T16:39:28Z

Great, thank you Peter!

laszlocsomor · 2017-12-18T10:32:47Z

Post-submit tests are https://ci.bazel.io/job/bazel/job/release/617/
The only errors are:

TF serving: this looks like CI, TF serving: fails in C++ compilation -- resolved #4289, and it's not a Bazel issue
TF syntaxnet: this is CI, TF_models_syntaxnet: failing with bazelrc read error #4290, and I think that's a flake.

I'll go ahead and push RC6 to release.

laszlocsomor · 2017-12-18T10:33:23Z

Ooops, not yet. 2 weeks have not yet passed since RC1.
I'm pushing it tomorrow then.

laszlocsomor · 2017-12-19T09:46:37Z

Pushed release:

@petemounce : Could you please update Chocolatey? Thanks!

@ilovezfs : I heard you were maintaining the Homebrew recipe. If that's indeed the case, thank you! Could you please update with 0.9.0? If you aren't, do you know who is?

ilovezfs · 2017-12-19T09:49:39Z

Voilà Homebrew/homebrew-core#21879

laszlocsomor · 2017-12-19T12:46:25Z

The last thing before we can close this bug is to update Chocolatey.

petemounce · 2017-12-19T14:40:21Z

Sorry, did that earlier, forgot to actually comment. https://chocolatey.org/packages/bazel/

laszlocsomor · 2017-12-20T08:32:33Z

Yay, thanks to both of you!

damienmg added the release label Sep 20, 2017

damienmg self-assigned this Sep 20, 2017

hlopko added category: misc > release / binary and removed category: misc > release / binary labels Oct 10, 2017

laszlocsomor self-assigned this Dec 5, 2017

This was referenced Dec 5, 2017

CI, bazel-nightly: rules_go and bazel-watcher are failing #4232

Closed

CI, bazel-nightly: TF, TF serving, and bazel-tests are failing #4233

Closed

damienmg unassigned damienmg and laszlocsomor Dec 14, 2017

laszlocsomor self-assigned this Dec 19, 2017

laszlocsomor mentioned this issue Dec 19, 2017

Release - January 2018 - Target RC date: 2017-01-02 - name: 0.10.0 #4325

Closed

laszlocsomor closed this as completed Dec 20, 2017

Release - December 2017 - Target RC date: 2017-12-01 - name: 0.9.0 #3773

Release - December 2017 - Target RC date: 2017-12-01 - name: 0.9.0 #3773

Comments

damienmg commented Sep 20, 2017

damienmg commented Nov 30, 2017

philwo commented Nov 30, 2017

damienmg commented Nov 30, 2017 via email

dslomov commented Nov 30, 2017 via email

philwo commented Nov 30, 2017

philwo commented Nov 30, 2017

philwo commented Nov 30, 2017

dslomov commented Nov 30, 2017

aj-michael commented Dec 1, 2017

damienmg commented Dec 4, 2017

damienmg commented Dec 4, 2017

damienmg commented Dec 4, 2017

damienmg commented Dec 4, 2017

jin commented Dec 4, 2017

laszlocsomor commented Dec 5, 2017 • edited Loading

laszlocsomor commented Dec 5, 2017 • edited Loading

laszlocsomor commented Dec 5, 2017 • edited Loading

petemounce commented Dec 5, 2017

laszlocsomor commented Dec 5, 2017

petemounce commented Dec 5, 2017

laszlocsomor commented Dec 6, 2017

damienmg commented Dec 6, 2017

laszlocsomor commented Dec 6, 2017 • edited Loading

laszlocsomor commented Dec 8, 2017 • edited Loading

laszlocsomor commented Dec 8, 2017 • edited Loading

laszlocsomor commented Dec 8, 2017

laszlocsomor commented Dec 8, 2017

petemounce commented Dec 9, 2017

laszlocsomor commented Dec 11, 2017

laszlocsomor commented Dec 11, 2017

laszlocsomor commented Dec 11, 2017

laszlocsomor commented Dec 12, 2017 • edited Loading

iirina commented Dec 12, 2017

laszlocsomor commented Dec 12, 2017

laszlocsomor commented Dec 12, 2017

laszlocsomor commented Dec 12, 2017

laszlocsomor commented Dec 12, 2017

ola-rozenfeld commented Dec 12, 2017 via email

laszlocsomor commented Dec 13, 2017

petemounce commented Dec 13, 2017

laszlocsomor commented Dec 13, 2017

laszlocsomor commented Dec 18, 2017

laszlocsomor commented Dec 18, 2017

laszlocsomor commented Dec 19, 2017

ilovezfs commented Dec 19, 2017

laszlocsomor commented Dec 19, 2017

petemounce commented Dec 19, 2017 • edited Loading

laszlocsomor commented Dec 20, 2017

laszlocsomor commented Dec 5, 2017 •

edited

Loading

laszlocsomor commented Dec 5, 2017 •

edited

Loading

laszlocsomor commented Dec 5, 2017 •

edited

Loading

laszlocsomor commented Dec 6, 2017 •

edited

Loading

laszlocsomor commented Dec 8, 2017 •

edited

Loading

laszlocsomor commented Dec 8, 2017 •

edited

Loading

laszlocsomor commented Dec 12, 2017 •

edited

Loading

petemounce commented Dec 19, 2017 •

edited

Loading