Skip to content

Optional static typing for Starlark #7468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hlopko opened this issue Feb 19, 2019 · 6 comments
Open

Optional static typing for Starlark #7468

hlopko opened this issue Feb 19, 2019 · 6 comments
Labels
not stale Issues or PRs that are inactive but not considered stale P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel type: feature request

Comments

@hlopko
Copy link
Member

hlopko commented Feb 19, 2019

Reading #7428 makes me feel like we have worse of both worlds - dynamic typing without dynamic lookup, or static lookup without type safety. If tooling and safety is a goal of Starlark, and it's ok to diverge from Python spec, what is Starlark's team opinion about optional static typing for Starlark?
@hlopko hlopko added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Starlark labels Feb 19, 2019
@hlopko
Copy link
Member Author

hlopko commented Feb 19, 2019

CC @lberki

@jin
Copy link
Member

jin commented Feb 19, 2019

💯 I would be very happy even if this is a standalone static typechecker.

@hlopko hlopko mentioned this issue Feb 20, 2019
Closed
@laurentlb
Copy link
Contributor

There have been a few discussions around this and it's on the list of project ideas (https://github.com/bazelbuild/bazel/wiki/Project-Ideas#static-type-checker-for-starlark).

See also https://groups.google.com/d/msg/bazel-dev/Pk9VrPCqby0/zoOL1IkxEAAJ
Previous request: https://groups.google.com/d/msg/bazel-dev/u-ass4pbK7U/aGQF72cjCAAJ

@brandjon brandjon added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Starlark labels Feb 17, 2021
@brandjon brandjon mentioned this issue Oct 27, 2022
Closed
@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 16, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@sgowroji sgowroji closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
@fmeum
Copy link
Collaborator

fmeum commented Feb 16, 2023

@sgowroji Please reopen, this is still relevant. Having Starlark support one of the optional type annotation methods available in Python would be very useful.

@sgowroji sgowroji reopened this Feb 16, 2023
@sgowroji sgowroji added not stale Issues or PRs that are inactive but not considered stale and removed stale Issues or PRs that are stale (no activity for 30 days) labels Feb 16, 2023
@jin jin mentioned this issue Jul 18, 2024
Open
6 tasks
@meisterT
Copy link
Member

meisterT commented Dec 6, 2024

See also: #22935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not stale Issues or PRs that are inactive but not considered stale P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jin @meisterT @laurentlb @hlopko @brandjon @fmeum @sgowroji