From 854de5d7871f734a858bf1efa4454e8260e620a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?X=C3=B9d=C5=8Dng=20Y=C3=A1ng?= Date: Tue, 5 Nov 2024 04:33:34 -0500 Subject: [PATCH] Add "skip_check" action type to bcr-pr-reviewer (#2102) Basically cut-pasted from release-helper. --- actions/bcr-pr-reviewer/action.yml | 2 +- actions/bcr-pr-reviewer/index.js | 37 ++++++++++++++++++++++++++++++ actions/release-helper/index.js | 7 ------ 3 files changed, 38 insertions(+), 8 deletions(-) diff --git a/actions/bcr-pr-reviewer/action.yml b/actions/bcr-pr-reviewer/action.yml index 5c5720832c..47933099bb 100644 --- a/actions/bcr-pr-reviewer/action.yml +++ b/actions/bcr-pr-reviewer/action.yml @@ -7,7 +7,7 @@ inputs: default: ${{ github.token }} action-type: - description: 'The type of action this reviewer should perform, valid values are: notify_maintainers, review_prs, dismiss_approvals' + description: 'The type of action this reviewer should perform, valid values are: notify_maintainers, review_prs, dismiss_approvals, skip_check' required: true runs: diff --git a/actions/bcr-pr-reviewer/index.js b/actions/bcr-pr-reviewer/index.js index 21369c2f64..0c00436301 100644 --- a/actions/bcr-pr-reviewer/index.js +++ b/actions/bcr-pr-reviewer/index.js @@ -442,6 +442,41 @@ async function runDismissApproval(octokit) { } } +const SKIP_CHECK_TRIGGER = "@bazel-io skip_check "; + +async function runSkipCheck(octokit) { + const payload = context.payload; + if (!payload.comment.body.startsWith(SKIP_CHECK_TRIGGER)) { + return; + } + const check = payload.comment.body.slice(SKIP_CHECK_TRIGGER.length); + const owner = payload.repository.owner.login; + const repo = payload.repository.name; + if (check == "unstable_url") { + await octokit.rest.issues.addLabels({ + owner, + repo, + issue_number: payload.issue.number, + labels: ["skip-url-stability-check"], + }); + await octokit.rest.reactions.createForIssueComment({ + owner, + repo, + comment_id: payload.comment.id, + content: '+1', + }); + } else { + await octokit.rest.reactions.createForIssueComment({ + owner, + repo, + comment_id: payload.comment.id, + content: 'confused', + }); + console.error(`unknown check: ${check}`); + setFailed(`unknown check: ${check}`); + } +} + async function run() { const action_type = getInput("action-type"); const token = getInput("token"); @@ -453,6 +488,8 @@ async function run() { await runPrReviewer(octokit); } else if (action_type === "dismiss_approvals") { await runDismissApproval(octokit); + } else if (action_type === "skip_check") { + await runSkipCheck(octokit); } else { console.log(`Unknown action type: ${action_type}`); } diff --git a/actions/release-helper/index.js b/actions/release-helper/index.js index 158aadacda..54cf0ff368 100644 --- a/actions/release-helper/index.js +++ b/actions/release-helper/index.js @@ -81,13 +81,6 @@ async function run() { issue_number: payload.issue.number, labels: [FLAGGED_LABEL], }); - } else if (command === "unstable_ack" || command.startsWith("unstable_ack ")) { - await octokit.rest.issues.addLabels({ - owner, - repo, - issue_number: payload.issue.number, - labels: ["skip-url-stability-check"], - }); } else { await octokit.rest.reactions.createForIssueComment({ owner,