Skip to content

Commit a041f5e

Browse files
authored
Use git info only when Expand to Working Set is enabled (#6944)
1 parent 0f0f910 commit a041f5e

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

base/src/com/google/idea/blaze/base/qsync/ProjectQuerierImpl.java

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.google.idea.blaze.base.logging.utils.querysync.SyncQueryStats;
2323
import com.google.idea.blaze.base.logging.utils.querysync.SyncQueryStatsScope;
2424
import com.google.idea.blaze.base.scope.BlazeContext;
25+
import com.google.idea.blaze.base.settings.BlazeUserSettings;
2526
import com.google.idea.blaze.base.vcs.BlazeVcsHandlerProvider.BlazeVcsHandler;
2627
import com.google.idea.blaze.common.vcs.VcsState;
2728
import com.google.idea.blaze.exception.BuildException;
@@ -120,15 +121,17 @@ public PostQuerySyncData update(
120121
ProjectDefinition currentProjectDef, PostQuerySyncData previousState, BlazeContext context)
121122
throws IOException, BuildException {
122123

123-
Optional<VcsState> vcsState = getVcsState(context);
124-
SyncQueryStatsScope.fromContext(context)
125-
.ifPresent(stats -> stats.setSyncMode(SyncQueryStats.SyncMode.DELTA));
126-
logger.info(
127-
String.format(
128-
"Starting partial query update; upstream rev=%s; snapshot path=%s",
129-
vcsState.map(s -> s.upstreamRevision).orElse("<unknown>"),
130-
vcsState.flatMap(s -> s.workspaceSnapshotPath).map(Object::toString).orElse("<none>")));
131-
124+
Optional<VcsState> vcsState = Optional.empty();
125+
if (BlazeUserSettings.getInstance().getExpandSyncToWorkingSet()) {
126+
vcsState = getVcsState(context);
127+
SyncQueryStatsScope.fromContext(context)
128+
.ifPresent(stats -> stats.setSyncMode(SyncQueryStats.SyncMode.DELTA));
129+
logger.info(
130+
String.format(
131+
"Starting partial query update; upstream rev=%s; snapshot path=%s",
132+
vcsState.map(s -> s.upstreamRevision).orElse("<unknown>"),
133+
vcsState.flatMap(s -> s.workspaceSnapshotPath).map(Object::toString).orElse("<none>")));
134+
}
132135
RefreshOperation refresh =
133136
projectRefresher.startPartialRefresh(
134137
context,

base/src/com/google/idea/blaze/base/sync/ProjectStateSyncTask.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
import com.google.idea.blaze.base.settings.Blaze;
4949
import com.google.idea.blaze.base.settings.BlazeImportSettings;
5050
import com.google.idea.blaze.base.settings.BlazeImportSettingsManager;
51+
import com.google.idea.blaze.base.settings.BlazeUserSettings;
5152
import com.google.idea.blaze.base.sync.SyncScope.SyncCanceledException;
5253
import com.google.idea.blaze.base.sync.SyncScope.SyncFailedException;
5354
import com.google.idea.blaze.base.sync.projectview.LanguageSupport;
@@ -125,7 +126,7 @@ private SyncProjectState getProjectState(BlazeContext context, BlazeSyncParams p
125126
createBazelInfoFuture(context, syncFlags, params.syncMode());
126127

127128
ListenableFuture<WorkingSet> workingSetFuture;
128-
if (params.addWorkingSet() || params.syncMode() == SyncMode.FULL) {
129+
if (params.addWorkingSet() || (BlazeUserSettings.getInstance().getExpandSyncToWorkingSet() && params.syncMode() == SyncMode.FULL)) {
129130
workingSetFuture = vcsHandler.getWorkingSet(context, executor);
130131
} else {
131132
workingSetFuture = Futures.immediateFuture(null);

0 commit comments

Comments
 (0)