Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tab-completion for targets in external workspaces #505

Open
cgruber opened this issue Feb 6, 2019 · 13 comments
Open

Support tab-completion for targets in external workspaces #505

cgruber opened this issue Feb 6, 2019 · 13 comments
Assignees
@mtoader
Labels
P1 I'll work on this now. (Assignee required) topic: bazel Bazel integration (external repositories, aspects, flags, etc) topic: external dependencies type: feature request

Comments

@cgruber
Copy link
Contributor

cgruber commented Feb 6, 2019

While click-through navigation now works for generated and downloaded workspaces, I'm not seeing syntax completion on targets not in //

e.g. using github.com/square/bazel_maven_repository, one can set up a generated workspace representing maven artifacts, and use a dependency like @maven//com/google/guava:guava. As of today, from a head-build, at least, I can click-through that target and end up in my generated BUILD.bazel file. All well and good.

But, when wanting to use it, I can't type @maven//com/google/gu and then hit tab, and have it offer me suggestions as it will for //blah/foo/ba+tab.
@jin jin added topic: bazel Bazel integration (external repositories, aspects, flags, etc) type: bug type: feature request and removed type: bug labels May 1, 2019
@arjantop
Copy link

Are there any plans to add this? Quite a usability downgrade when using bazelbuild/rules_jvm_external (compared to bazel-deps).

@jin jin self-assigned this Jul 16, 2019
@jin
Copy link
Member

jin commented Jul 16, 2019

I'll take a look at this.

@arjantop
Copy link

@jin Great, thanks!

@jin jin mentioned this issue Aug 13, 2019
Closed
@jin jin removed their assignment May 6, 2020
@lukaciko
Copy link

@jin @mai93 any updates on this? I see there was a draft branch a long time ago and that the issue has been tagged with topic: external dependencies.

@Bencodes
Copy link

Has any progress been made on this one? We also heavily use rules_jvm_external and having auto-complete support for this would be a huge quality-of-life improvement for our users.

@Bencodes
Copy link

Bencodes commented Sep 14, 2022 •
edited
Loading

@sgowroji this is another low hanging bug that impacts most Java/Android teams. Could you help triage this one as well?

@sgowroji sgowroji added the awaiting-maintainer Awaiting review from Bazel team on issues label Nov 29, 2022
@mai93 mai93 added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Dec 12, 2022
@mai93 mai93 removed their assignment Dec 12, 2022
@mai93 mai93 removed the awaiting-maintainer Awaiting review from Bazel team on issues label Dec 12, 2022
@github-actions
Copy link

Thank you for contributing to the IntelliJ repository! This issue has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-maintainer". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jun 14, 2023
@keertk keertk moved this from Untriaged to Backlog in Bazel IntelliJ Plugin Jun 15, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Bazel IntelliJ Plugin Jun 28, 2023
@Bencodes
Copy link

Not being able to auto complete external dependencies is still an issue that exists in the Intellij plugin. Would be great to see a fix for this.

@mai93 mai93 reopened this Feb 23, 2024
@github-project-automation github-project-automation bot moved this from Done to Untriaged in Bazel IntelliJ Plugin Feb 23, 2024
@mai93 mai93 removed the stale Issues or PRs that are stale (no activity for 30 days) label Feb 23, 2024
@github-actions GitHub Actions
Copy link

Thank you for contributing to the IntelliJ repository! This issue has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Aug 25, 2024
@tpasternak
Copy link
Contributor

Probably will be fixed in #6664

@mtoader
Copy link
Contributor

mtoader commented Aug 30, 2024 •
edited
Loading

Yea. Working on adding this :) @tpasternak is it possible that I get assigned to this ?

@mai93 mai93 removed the stale Issues or PRs that are stale (no activity for 30 days) label Aug 30, 2024
@tpasternak
Copy link
Contributor

Sure! I can even mark as P1!

@tpasternak tpasternak added P1 I'll work on this now. (Assignee required) and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Sep 2, 2024
mtoader added a commit to mtoader/intellij that referenced this issue Sep 4, 2024
@mtoader
[bazelbuild#6664]: Enable External Workspace completions and tests
1c2330e 
  Also add a CharFilter impl that allows `@` to filter the lookup elements and not hide the lookup

  Other issues: bazelbuild#505
mtoader added a commit to mtoader/intellij that referenced this issue Sep 4, 2024
@mtoader
[bazelbuild#6664]: Enable External Workspace completions and tests
4c0df7c 
  Also add a CharFilter that enable:
    * '@' to filter the lookup elements and not hide the lookup.
    * '/' to autocomplete selected item

  Other issues: bazelbuild#505
mtoader added a commit to mtoader/intellij that referenced this issue Sep 4, 2024
@mtoader
[bazelbuild#6664]: Enable External Workspace completions and tests
80baa23 
  Also add a CharFilter that enable:
    * '@' to filter the lookup elements and not hide the lookup.
    * '/' to autocomplete selected item

  Other issues: bazelbuild#505
mtoader added a commit to mtoader/intellij that referenced this issue Sep 5, 2024
@mtoader
[bazelbuild#6664]: Enable External Workspace completions and tests
c222e4e 
  Also add a CharFilter that enable:
    * '@' to filter the lookup elements and not hide the lookup.
    * '/' to autocomplete selected item

  Other issues: bazelbuild#505
@mtoader mtoader mentioned this issue Sep 5, 2024
Merged
3 tasks
tpasternak pushed a commit that referenced this issue Sep 5, 2024
@mtoader
[#6664]: Enable External Workspace completions and tests (#6730)
1619853 
Also add a CharFilter that enable:
    * '@' to filter the lookup elements and not hide the lookup.
    * '/' to autocomplete selected item

  Other issues: #505
@mtoader mtoader mentioned this issue Sep 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtoader mtoader

Labels
P1 I'll work on this now. (Assignee required) topic: bazel Bazel integration (external repositories, aspects, flags, etc) topic: external dependencies type: feature request
Projects
Bazel IntelliJ Plugin
Status: Untriaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: external repo targets autocomplete in BUILD files jin/intellij
9 participants
@arjantop @cgruber @jin @mtoader @tpasternak @Bencodes @lukaciko @sgowroji @mai93