Skip to content

Commit d482bb2

Browse files
authored
Revert "Embed frameworks in ios_message_extension (#1706)" (#2631)
This reverts commit 75afaa2. I tried uploading an app we're moving to Bazel to ASC today and got this back from altool: ``` [ContentDelivery.Uploader.6000035C02C0] Asset validation failed (90685) CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'io.sentry.Sentry' under the iOS application 'Dropbox.app'. (ID: 70764510-61df-4d35-a5ae-c58c46bcd2ec) [ContentDelivery.Uploader.6000035C02C0] Asset validation failed (90205) Invalid Bundle. The bundle at 'Dropbox.app/PlugIns/DropboxMessageExtension.appex' contains disallowed nested bundles. Refer to https://developer.apple.com/go/?id=framework-imessage for a workaround. (ID: 7dcc5f1e-43d3-4eee-965f-74af1e0a8ed8) [ContentDelivery.Uploader.6000035C02C0] Asset validation failed (90206) Invalid Bundle. The bundle at 'Dropbox.app/PlugIns/DropboxMessageExtension.appex' contains disallowed file 'Frameworks'. (ID: 731b294a-ceb5-40fa-b1b6-8dcd76124934) Error uploading '/var/folders/yk/2ntskjpj28l6pt3w5q_693mw0000gn/T/a672ce89-fff4-4f35-87d9-1bc5b4b9c39e.ipa'. ``` It appears as though iMessage extensions cannot have embedded frameworks, and this change has made it so that one of our framework deps is getting pulled in and bundled.
1 parent 710570f commit d482bb2

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

apple/internal/ios_rules.bzl

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2246,16 +2246,6 @@ def _ios_imessage_extension_impl(ctx):
22462246
rule_label = label,
22472247
targets_to_validate = ctx.attr.frameworks,
22482248
),
2249-
partials.framework_import_partial(
2250-
actions = actions,
2251-
apple_mac_toolchain_info = apple_mac_toolchain_info,
2252-
features = features,
2253-
label_name = label.name,
2254-
platform_prerequisites = platform_prerequisites,
2255-
provisioning_profile = provisioning_profile,
2256-
rule_descriptor = rule_descriptor,
2257-
targets = ctx.attr.deps + ctx.attr.frameworks,
2258-
),
22592249
partials.resources_partial(
22602250
actions = actions,
22612251
apple_mac_toolchain_info = apple_mac_toolchain_info,

0 commit comments

Comments
 (0)