Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for missing configuration in rules based toolchain #332

Open
keith opened this issue Jan 29, 2025 · 2 comments · May be fixed by #355
Open

Add support for missing configuration in rules based toolchain #332

keith opened this issue Jan 29, 2025 · 2 comments · May be fixed by #355
Assignees
@armandomontanez

Comments

@keith
Copy link
Member

keith commented Jan 29, 2025

If you want to create a toolchain targeting macOS, you very likely want these features:

    # macOS artifact name patterns differ from the defaults only for dynamic
    # libraries.
    artifact_name_patterns = [
        artifact_name_pattern(
            category_name = "dynamic_library",
            prefix = "lib",
            extension = ".dylib",
        ),
    ]

    make_variables = [
        make_variable(
            name = "STACK_FRAME_UNLIMITED",
            value = "-Wframe-larger-than=100000000 -Wno-vla",
        ),
    ]

These are set on create_cc_toolchain_config_info https://github.com/bazelbuild/apple_support/blob/af8d93a33586c80bf2d245922ce31fcd109fe645/crosstool/cc_toolchain_config.bzl#L2798-L2809

And today there is no way to do this. I assume it would be preferred to create some sort of rule representing these?
@armandomontanez armandomontanez self-assigned this Jan 29, 2025
@keith
Copy link
Member Author

keith commented Jan 29, 2025

example hack people can patch in if they want to for now #342

@keith
Copy link
Member Author

keith commented Feb 7, 2025

here's 1 #355

@Yannic Yannic linked a pull request Feb 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armandomontanez armandomontanez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rule-based toolchains] Add rules to define artifact_name_pattern EngFlow/rules_cc
2 participants
@keith @armandomontanez