From cdb2b3e8148dc72c08b406e6ecb82cbeb9561705 Mon Sep 17 00:00:00 2001 From: Xavier Bonaventura Date: Tue, 2 Dec 2025 19:33:55 +0100 Subject: [PATCH] Remove the false impresion that some bzl files are not public The value of INTERNAL_VISIBILIY variable was changed to public. However, the name of the variable seems to imply that it is not public. Removing it makes that clear. --- cc/common/BUILD | 8 -------- cc/common/cc_debug_helper.bzl | 3 +-- cc/common/cc_helper.bzl | 3 +-- cc/common/visibility.bzl | 3 --- 4 files changed, 2 insertions(+), 15 deletions(-) delete mode 100644 cc/common/visibility.bzl diff --git a/cc/common/BUILD b/cc/common/BUILD index d5648074c..1530d156d 100644 --- a/cc/common/BUILD +++ b/cc/common/BUILD @@ -41,7 +41,6 @@ bzl_library( deps = [ ":cc_helper_internal_bzl", ":common", - ":visibility_bzl", "//cc:find_cc_toolchain_bzl", "//cc/private:paths_bzl", "//cc/private/rules_impl:objc_common", @@ -80,17 +79,10 @@ bzl_library( visibility = ["//visibility:public"], deps = [ ":cc_helper_bzl", - ":visibility_bzl", "//cc:find_cc_toolchain_bzl", ], ) -bzl_library( - name = "visibility_bzl", - srcs = ["visibility.bzl"], - visibility = ["//visibility:private"], -) - filegroup( name = "srcs", srcs = glob([ diff --git a/cc/common/cc_debug_helper.bzl b/cc/common/cc_debug_helper.bzl index 70e442a08..1ffde11b5 100644 --- a/cc/common/cc_debug_helper.bzl +++ b/cc/common/cc_debug_helper.bzl @@ -17,9 +17,8 @@ load("//cc:action_names.bzl", "ACTION_NAMES") load("//cc:find_cc_toolchain.bzl", "CC_TOOLCHAIN_TYPE") load(":cc_common.bzl", "cc_common") load(":cc_helper.bzl", "linker_mode") -load(":visibility.bzl", "INTERNAL_VISIBILITY") -visibility(INTERNAL_VISIBILITY) +visibility("public") def create_debug_packager_actions( ctx, diff --git a/cc/common/cc_helper.bzl b/cc/common/cc_helper.bzl index 51f2309bf..cea914896 100644 --- a/cc/common/cc_helper.bzl +++ b/cc/common/cc_helper.bzl @@ -30,9 +30,8 @@ load( _repository_exec_path = "repository_exec_path", ) load(":cc_info.bzl", "CcInfo") -load(":visibility.bzl", "INTERNAL_VISIBILITY") -visibility(INTERNAL_VISIBILITY) +visibility("public") # LINT.IfChange(linker_mode) linker_mode = struct( diff --git a/cc/common/visibility.bzl b/cc/common/visibility.bzl deleted file mode 100644 index 981ce86ca..000000000 --- a/cc/common/visibility.bzl +++ /dev/null @@ -1,3 +0,0 @@ -"""Bzl load visibility package specs""" - -INTERNAL_VISIBILITY = ["public"]