Skip to content

Commit 9f58706

Browse files
authored
Update protobuf test to use jssuite from forked files (#636)
* Update protobuf test to use jssuite from forked files * Update bazel version * Update protobuf test to use jssuite from forked files * Update protobuf test to use jssuite from forked files and remove usage of assertHTMLEquals * Remove legacy protobuf test * Add back legacy test * Add a blank line at the end of legacy example test * Update legacy test to use forked jsunit and asserts * Update legacy test to use forked jsunit and asserts * Add back require line and remove additional msg.field()
1 parent 9b79a03 commit 9f58706

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

closure/protobuf/test/BUILD

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ closure_js_test(
5252
],
5353
deps = [
5454
":foo",
55-
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
55+
"//closure/testing/library:testsuite",
5656
],
5757
)
5858

@@ -95,7 +95,7 @@ closure_js_test(
9595
deps = [
9696
":baz",
9797
":foo",
98-
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
98+
"//closure/testing/library:testsuite",
9999
],
100100
)
101101

@@ -131,6 +131,6 @@ closure_js_test(
131131
],
132132
deps = [
133133
":bat",
134-
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
134+
"//closure/testing/library:testsuite",
135135
],
136136
)

closure/protobuf/test/legacy/BUILD

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ closure_js_test(
4040
srcs = ["example_test.js"],
4141
deps = [
4242
":example_lib",
43-
"@com_google_javascript_closure_library//closure/goog/testing:asserts",
44-
"@com_google_javascript_closure_library//closure/goog/testing:jsunit",
43+
"//closure/testing/library:asserts",
44+
"//closure/testing/library:jsunit",
4545
],
4646
)

closure/protobuf/test/legacy/example_test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,5 @@ goog.require('io.bazel.rules.closure.protobuf.Example');
1919

2020
function testExample() {
2121
var msg = new io.bazel.rules.closure.protobuf.Example('value');
22-
msg.field();
23-
assertHTMLEquals('value', msg.field());
22+
assertEquals('value', msg.field());
2423
}

0 commit comments

Comments
 (0)