Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a new release past 0.10.0 #497

Closed
mbrukman opened this issue Aug 23, 2020 · 2 comments
Closed

Please create a new release past 0.10.0 #497

mbrukman opened this issue Aug 23, 2020 · 2 comments

Comments

@mbrukman
Copy link
Contributor

The latest release (0.10.0) is from Oct 2019, which is quite old, and I've run into some issues with it, as mentioned in #496, some of which have been fixed in the repo, so I am using an unnamed git commit hash instead of a release version.

Would it be possible to create a newer release with all the changes that have been made since 0.10.0 to make it easier for everyone to get the latest improvements and bug fixes?

Thanks!

@mbrukman
Copy link
Contributor Author

While release 0.10.0 works locally on macOS, it fails on Travis CI:

$ bazel build --config=ci //...
Extracting Bazel installation...
................
ERROR: /private/var/tmp/_bazel_travis/616ba4a0fc6920c1316870693f99fc06/external/io_bazel_rules_closure/closure/protobuf/closure_proto_library.bzl:66:21: name 'ProtoInfo' is not defined
ERROR: error loading package 'third_party/preact-without-babel': Extension 'closure/protobuf/closure_proto_library.bzl' has errors
ERROR: error loading package 'third_party/preact-without-babel': Extension 'closure/protobuf/closure_proto_library.bzl' has errors
INFO: Elapsed time: 2.814s
The command "bazel build --config=ci //..." exited with 1.

Here's the .bazelrc used in that run:

build:ci --noshow_progress --noshow_loading_progress --verbose_failures

And here's the WORKSPACE from that run:

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_closure",
    sha256 = "7d206c2383811f378a5ef03f4aacbcf5f47fd8650f6abbc3fa89f3a27dd8b176",
    strip_prefix = "rules_closure-0.10.0",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_closure/archive/0.10.0.tar.gz",
        "https://github.com/bazelbuild/rules_closure/archive/0.10.0.tar.gz",
    ],
)

load("@io_bazel_rules_closure//closure:repositories.bzl", "rules_closure_dependencies", "rules_closure_toolchains")
rules_closure_dependencies()
rules_closure_toolchains()

@gkdn
Copy link
Collaborator

gkdn commented Aug 31, 2020

Added new release.

(The issue you are seeing is related to bazel versions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants