From e44d8127b1b361c6805a8db9c7e1f143232981fd Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Wed, 1 May 2024 17:16:06 -0700 Subject: [PATCH 1/2] fix: rules_cc is not a dev_dependency Since the tools/file_concat program is written in C++ and exposed to users of proto_descriptor_set, we depend on rules_cc at runtime. --- MODULE.bazel | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MODULE.bazel b/MODULE.bazel index d69b785..e7a61c2 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -7,13 +7,14 @@ module( compatibility_level = 1, ) +# TODO(#203): remove dependency on compiling C++ tools +bazel_dep(name = "rules_cc", version = "0.0.1") bazel_dep(name = "rules_license", version = "0.0.7") bazel_dep(name = "bazel_skylib", version = "1.3.0") bazel_dep(name = "bazel_features", version = "1.4.1") # Dependencies needed in tests bazel_dep(name = "stardoc", version = "0.5.6", dev_dependency = True, repo_name = "io_bazel_stardoc") -bazel_dep(name = "rules_cc", version = "0.0.1", dev_dependency = True) bazel_dep(name = "googletest", version = "1.11.0", dev_dependency = True, repo_name = "com_google_googletest") bazel_dep(name = "protobuf", version = "23.1", dev_dependency = True, repo_name = "com_google_protobuf") bazel_dep(name = "platforms", version = "0.0.8", dev_dependency = True) From 5c31e40fa3657484eba30ee7ce48798b8e4609b3 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Thu, 23 May 2024 12:21:12 -0700 Subject: [PATCH 2/2] Update MODULE.bazel --- MODULE.bazel | 1 - 1 file changed, 1 deletion(-) diff --git a/MODULE.bazel b/MODULE.bazel index e7a61c2..80d185b 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -7,7 +7,6 @@ module( compatibility_level = 1, ) -# TODO(#203): remove dependency on compiling C++ tools bazel_dep(name = "rules_cc", version = "0.0.1") bazel_dep(name = "rules_license", version = "0.0.7") bazel_dep(name = "bazel_skylib", version = "1.3.0")