Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate_universe builds not forwarding environment variables from env section of cargo_config ? #2901

Open
sthornington opened this issue Sep 25, 2024 · 2 comments

Comments

@sthornington
Copy link
Contributor

We have TIMENS_TZ_FILTER set in the env section of the cargo_config toml file, but it doesn't appear to be getting forwarded to the cargo build of the timens crate - is this section supported by rules rust?

@UebelAndre
Copy link
Collaborator

Ah, that’s definitely something I didn’t think about. I think if the config is in the repo then it would be fair to render the environment variables but what about configs on the system (~/.cargo/config.toml)? I feel like those should be ignored?

I’m happy to review a PR for this :)

@sthornington
Copy link
Contributor Author

Understood, any hints on where to begin would be appreciated. I didn't think that system cargo configs were even parsed? There's that error that emits if one is even in the parent directories of the bazel workspace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants