BADGERS-535: publish error when segment download fails on final CDN (#347)

* throw error when init segment/content download on final CDN fails

Author: tom-coward

src/playbackstrategy/msestrategy.js

@@ -217,8 +217,9 @@ function MSEStrategy(mediaSources, windowType, mediaKind, playbackElement, isUHD
 
       // Don't raise an error on fragment download error
       if (
-        event.error.code === DashJSEvents.DOWNLOAD_CONTENT_ERROR_CODE ||
-        event.error.code === DashJSEvents.DOWNLOAD_INIT_SEGMENT_ERROR_CODE
+        (event.error.code === DashJSEvents.DOWNLOAD_CONTENT_ERROR_CODE ||
+          event.error.code === DashJSEvents.DOWNLOAD_INIT_SEGMENT_ERROR_CODE) &&
+        mediaSources.availableSources().length > 1
       ) {
         return
       }

src/playbackstrategy/msestrategy.test.js

@@ -1241,7 +1241,7 @@ describe("Media Source Extensions Playback Strategy", () => {
       expect(Plugins.interface.onErrorHandled).not.toHaveBeenCalledWith()
     })
 
-    it("should not publish error event on initial segment download error", () => {
+    it("should not publish error event on init segment download error if more than one CDN available", () => {
       const mockEvent = {
         error: {
           message: "initial segment download error",
@@ -1261,7 +1261,31 @@ describe("Media Source Extensions Playback Strategy", () => {
       expect(mockErrorCallback).not.toHaveBeenCalled()
     })
 
-    it("should not publish error event on content download error", () => {
+    it("should publish error event on init segment download error if only one CDN available", () => {
+      const mockEvent = {
+        error: {
+          message: "initial segment download error",
+          code: 28,
+        },
+      }
+
+      setUpMSE()
+
+      const mockErrorCallback = jest.fn()
+      mseStrategy.addErrorCallback(null, mockErrorCallback)
+
+      mseStrategy.load(null, 0)
+
+      const noop = () => {}
+      mediaSources.failover(noop, noop, { isBufferingTimeoutError: true })
+      mediaSources.failover(noop, noop, { isBufferingTimeoutError: true })
+
+      dashEventCallback(dashjsMediaPlayerEvents.ERROR, mockEvent)
+
+      expect(mockErrorCallback).toHaveBeenCalled()
+    })
+
+    it("should not publish error event on content download error if more than one CDN available", () => {
       const mockEvent = {
         error: {
           message: "content download error",
@@ -1281,6 +1305,30 @@ describe("Media Source Extensions Playback Strategy", () => {
       expect(mockErrorCallback).not.toHaveBeenCalled()
     })
 
+    it("should publish error event on content download error if only one CDN available", () => {
+      const mockEvent = {
+        error: {
+          message: "content download error",
+          code: 27,
+        },
+      }
+
+      setUpMSE()
+
+      const mockErrorCallback = jest.fn()
+      mseStrategy.addErrorCallback(null, mockErrorCallback)
+
+      mseStrategy.load(null, 0)
+
+      const noop = () => {}
+      mediaSources.failover(noop, noop, { isBufferingTimeoutError: true })
+      mediaSources.failover(noop, noop, { isBufferingTimeoutError: true })
+
+      dashEventCallback(dashjsMediaPlayerEvents.ERROR, mockEvent)
+
+      expect(mockErrorCallback).toHaveBeenCalled()
+    })
+
     it("should initiate a failover with correct parameters on manifest download error", () => {
       const mockEvent = {
         error: {