Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Incorrect check for invalid positions #416

@dennwc

Description

@dennwc

In SDK we have a method that checks if a position is valid. But the "valid" is not defined precisely. For example, the SDK expects it to mean "position is set at least partially", while user-facing code like iterators assumes it means "values used in positions are in a valid range".

We must first define a separate function that checks the range (e.g. offset >= 0), and then find and update all the places that expect this condition to hold.

The quick fix would be to add a check to the positional iterator specifically.

Related to bblfsh/python-client#172

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions