Skip to content

Commit 6bee45c

Browse files
authored
Merge pull request #559 from bcgov/ccfri-3694-debug-puppeteer
fix: dead browser instance after one PDF run
2 parents 5ce1b38 + ad53564 commit 6bee45c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

backend/src/util/browser.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ let browser = null;
1414
async function getBrowserContext() {
1515
try {
1616
if (browser instanceof puppeteer.Browser && browser.process() !== null) {
17-
return browser;
17+
log.info('Puppeteer :: getBrowserContext reusing browser process');
18+
return browser.createBrowserContext();
1819
}
1920
// To debug locally add {headless: false, devtools: true} in options
2021
// make sure they are boolean and not string
@@ -57,6 +58,7 @@ async function closeBrowser() {
5758
const pages = await browser.pages();
5859
if (pages.length === 1) {
5960
await browser.close();
61+
browser = null;
6062
} else {
6163
log.warn('Puppeteer :: closeBrowser was called with pages open');
6264
}

0 commit comments

Comments
 (0)