Skip to content

Commit eeddbc0

Browse files
authored
Merge pull request #578 from bcgov/deprecating-deployment-configs
fix: indistinguishable matchLabels across envs
2 parents 2569e1f + 26b7aeb commit eeddbc0

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

tools/openshift/backend.deployment.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ objects:
1212
annotations:
1313
openshift.io/generated-by: OpenShiftNewApp
1414
labels:
15-
app: "${APP_NAME}-backend-deployment"
15+
app: "${APP_NAME}-backend-${APP_ENVIRONMENT}-deployment"
1616
branch: "${BRANCH}"
1717
name: "${APP_NAME}-backend-${APP_ENVIRONMENT}"
1818
spec:
1919
replicas: ${{MIN_REPLICAS}}
2020
selector:
2121
matchLabels:
22-
app: "${APP_NAME}-backend-deployment"
22+
app: "${APP_NAME}-backend-${APP_ENVIRONMENT}-deployment"
2323
strategy:
2424
type: RollingUpdate
2525
rollingUpdate:
@@ -30,7 +30,7 @@ objects:
3030
annotations:
3131
openshift.io/generated-by: OpenShiftNewApp
3232
labels:
33-
app: "${APP_NAME}-backend-deployment"
33+
app: "${APP_NAME}-backend-${APP_ENVIRONMENT}-deployment"
3434
spec:
3535
containers:
3636
- image: image-registry.openshift-image-registry.svc:5000/${NAMESPACE}/${REPO_NAME}-backend-${BRANCH}:${TAG}
@@ -132,7 +132,7 @@ objects:
132132
service.alpha.openshift.io/serving-cert-secret-name: "ccof-backend-cert"
133133
openshift.io/generated-by: OpenShiftNewApp
134134
labels:
135-
app: "${APP_NAME}-backend-deployment"
135+
app: "${APP_NAME}-backend-${APP_ENVIRONMENT}-deployment"
136136
name: "${APP_NAME}-backend-${APP_ENVIRONMENT}"
137137
spec:
138138
ports:
@@ -145,7 +145,7 @@ objects:
145145
protocol: TCP
146146
targetPort: 443
147147
selector:
148-
app: "${APP_NAME}-backend-deployment"
148+
app: "${APP_NAME}-backend-${APP_ENVIRONMENT}-deployment"
149149
- apiVersion: v1
150150
kind: Route
151151
metadata:
@@ -156,7 +156,7 @@ objects:
156156
haproxy.router.openshift.io/timeout: 120s
157157
openshift.io/host.generated: 'true'
158158
labels:
159-
app: "${APP_NAME}-backend-deployment"
159+
app: "${APP_NAME}-backend-${APP_ENVIRONMENT}-deployment"
160160
name: "${APP_NAME}-backend-${APP_ENVIRONMENT}"
161161
spec:
162162
host: "${HOST_ROUTE}"

tools/openshift/frontend.deployment.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
annotations:
1313
openshift.io/generated-by: OpenShiftNewApp
1414
labels:
15-
app: "${APP_NAME}-frontend-deployment"
15+
app: "${APP_NAME}-frontend-${APP_ENVIRONMENT}-deployment"
1616
branch: "${BRANCH}"
1717
name: "${APP_NAME}-frontend-${APP_ENVIRONMENT}"
1818
spec:
1919
replicas: ${{MIN_REPLICAS}}
2020
selector:
2121
matchLabels:
22-
app: "${APP_NAME}-frontend-deployment"
22+
app: "${APP_NAME}-frontend-${APP_ENVIRONMENT}-deployment"
2323
strategy:
2424
type: RollingUpdate
2525
rollingUpdate:
@@ -30,7 +30,7 @@
3030
annotations:
3131
openshift.io/generated-by: OpenShiftNewApp
3232
labels:
33-
app: "${APP_NAME}-frontend-deployment"
33+
app: "${APP_NAME}-frontend-${APP_ENVIRONMENT}-deployment"
3434
spec:
3535
containers:
3636
- image: image-registry.openshift-image-registry.svc:5000/${NAMESPACE}/${REPO_NAME}-frontend-${BRANCH}:${TAG}
@@ -85,7 +85,7 @@
8585
service.alpha.openshift.io/serving-cert-secret-name: "ccof-frontend-cert"
8686
openshift.io/generated-by: OpenShiftNewApp
8787
labels:
88-
app: "${APP_NAME}-frontend-deployment"
88+
app: "${APP_NAME}-frontend-${APP_ENVIRONMENT}-deployment"
8989
name: "${APP_NAME}-frontend-${APP_ENVIRONMENT}"
9090
spec:
9191
ports:
@@ -94,14 +94,14 @@
9494
protocol: TCP
9595
targetPort: 2015
9696
selector:
97-
app: "${APP_NAME}-frontend-deployment"
97+
app: "${APP_NAME}-frontend-${APP_ENVIRONMENT}-deployment"
9898
- apiVersion: v1
9999
kind: Route
100100
metadata:
101101
annotations:
102102
openshift.io/host.generated: 'true'
103103
labels:
104-
app: "${APP_NAME}-frontend-deployment"
104+
app: "${APP_NAME}-frontend-${APP_ENVIRONMENT}-deployment"
105105
name: "${APP_NAME}-frontend-${APP_ENVIRONMENT}"
106106
spec:
107107
host: "${HOST_ROUTE}"

0 commit comments

Comments
 (0)