From a6573a577ae8300edc8459a366f6af069788fdbc Mon Sep 17 00:00:00 2001
From: soletsdev <soletsdev@github>
Date: Wed, 7 Feb 2024 15:36:02 -0800
Subject: [PATCH] updating jacoco to try to include test coverage. code cleanup

---
 api/pom.xml                                                     | 2 +-
 .../api/service/StudentRegistrationContactServiceTest.java      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/api/pom.xml b/api/pom.xml
index a5385c61..730c4b94 100644
--- a/api/pom.xml
+++ b/api/pom.xml
@@ -272,7 +272,7 @@
         <plugin>
           <groupId>org.jacoco</groupId>
           <artifactId>jacoco-maven-plugin</artifactId>
-          <version>0.8.4</version>
+          <version>0.8.8</version>
         </plugin>
         <plugin>
           <groupId>org.hibernate.orm.tooling</groupId>
diff --git a/api/src/test/java/ca/bc/gov/educ/penreg/api/service/StudentRegistrationContactServiceTest.java b/api/src/test/java/ca/bc/gov/educ/penreg/api/service/StudentRegistrationContactServiceTest.java
index 17d6aaa0..0b76b01e 100644
--- a/api/src/test/java/ca/bc/gov/educ/penreg/api/service/StudentRegistrationContactServiceTest.java
+++ b/api/src/test/java/ca/bc/gov/educ/penreg/api/service/StudentRegistrationContactServiceTest.java
@@ -63,6 +63,6 @@ public void testGetStudentRegistrationContactEmailsByMincode_givenDifferentInput
     String mincodeNotExist = "123546789";
     when(this.restUtils.getStudentRegistrationContactList(mincodeNotExist)).thenReturn(studentRegistrationContactMap.get(mincodeNotExist));
     var dataList2 = this.service.getStudentRegistrationContactEmailsByMincode(mincodeNotExist);
-    assertThat(dataList2).hasSize(0);
+    assertThat(dataList2).isEmpty();
   }
 }