Merge pull request #581 from bcgov/yj

chore: performance
bcgov · Aug 29, 2024 · 3d22e16 · 3d22e16
2 parents 0b6e400 + 644ac08
commit 3d22e16
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/server/StrDss.Data/Repositories/RentalListingRepository.cs b/server/StrDss.Data/Repositories/RentalListingRepository.cs
@@ -218,7 +218,9 @@ private async Task<List<RentalListingViewDto>> GetRentalListings(string? effecti
 
             ApplyFilters(all, address, url, listingId, hostName, businessLicence, prRequirement, blRequirement, lgId, statusArray, reassigned, takedownComplete, ref query);
 
-            var filteredIds = await query.Select(x => x.RentalListingId).ToListAsync();
+            var filteredIds = await query.Select(x => x.RentalListingId ?? 0).ToListAsync();
+
+            var filteredIdSet = new HashSet<long>(filteredIds);
 
             stopwatch.Stop();
 
@@ -242,7 +244,7 @@ await _dbSet.AsNoTracking()
             {
                 await SetExtraProperties(listing);
 
-                listing.Filtered = filteredIds.Contains(listing.RentalListingId);
+                listing.Filtered = filteredIdSet.Contains(listing.RentalListingId ?? 0);
 
                 group.NightsBookedYtdQty += listing.NightsBookedYtdQty ?? 0;
             }