Project summary report creating duplicate form_change records [7+]

[mikevespi]

Describe the Bug:

It was reported by the CIF team in a Teams thread on 9/27/2023 that some IA projects were unable to commit project revisions that were adding a project summary report (it's worth noting that in that thread there are 3 or 4 different projects mentioned so far, but this is not the cause of all of them). When the Project summary report due date is set in the form, the duplicate record does not get the update, resulting in a validation error missing the required field. This prevents the entire project revision from being applied, and the team have reported having incorrect due dates in the system as a result.

At this point, I have been able to recreate the bug locally only using multiple tabs clicking the "Add project summary report" button in quick succession and in separate tabs. This indicates that it could be a potential network problem just allowing the create mutation to be sent twice if the button is clicked twice before the initial create is resolved, resulting in two separate form_change records.

When this happens, the form shows attention required in the sidebar but in the summary we can see the report due date entered. When you try to apply it, you get "You can not commit this revision/amendment. Please see "Attention Required".

To unblock the project revisions that are currently blocked by this, you need to delete the form_change record that has the validation error in it on the problematic project_revision. That is, there will be two records for the same revision with the json_schema_name of project_summary_report. One of them will have the report due date that has been entered, and the other will not. The one without it will have a non-empty array of validation errors. That is the record that needs to be deleted.

As for preventing it, start with something as simple as disabling the button that creates the report form while the request is being resolved.

Probability (how likely the bug is to happen, scored from 1-5): 3+
(For example, probability of 5 is something like "it happens to all users every time they log in."
Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")

Effect (how bad the bug is when it does happen, scored from 1-5):4
(For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected."
Effect of 1 is "It makes some styling look a little bit weird.")

Steps to reproduce the behaviour:

Screenshots:
Can be found in the Teams threads but cannot be shared here as they are sensitive.

Additional information:

• OS: [e.g. iOS]
• Browser: [e.g. chrome, safari]
• Version: [e.g. 22]
• Additional context