Add unit tests to remaining sync related controllers #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the terminate signal would come in, but the queue would continue working for another 3 seconds or so before halting itself. We change it up so that when the signal comes in, it immediately tells the queue to stop before doing the 3 second grace period to kill the database connection. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
There are situations where the spinlock causes a stack overflow instead of properly waiting for the isBusy state to change. We deal with this by inverting the control flow to insert in a stored callback reference and then invoking the callback when isBusy is assigned a false value. This approach removes the need to poll frequently and instead defers it to the setter to do the work at the right time. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Skipped trxWrapper coverage due to mock autowiring difficulties Signed-off-by: Jeremy Ho <jujaga@gmail.com>
|
Code Climate has analyzed commit 3f65f94 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (3.1% change). View more on Code Climate. |
Coverage Report
|
TimCsaky
approved these changes
Sep 19, 2023
norrisng-bc
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more unit tests to cover off loose ends related to synchronization. It also modifies shutdown behavior so that the pod immediately finishes handling the queue on signal instead of continuing work for another 3 seconds.
SHOWCASE-3328
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments