Skip to content

Commit 287fbeb

Browse files
Update Join from Request ID to Key
1 parent 4f42ae4 commit 287fbeb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

analytics-api/src/analytics_api/models/request_type_option.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ def get_survey_result(
3434
if can_view_all_survey_results:
3535
survey_question = (db.session.query(RequestTypeOption.position.label('position'),
3636
RequestTypeOption.label.label('label'),
37-
RequestTypeOption.request_id)
37+
RequestTypeOption.key)
3838
.filter(and_(RequestTypeOption.survey_id.in_(analytics_survey_id),
3939
RequestTypeOption.is_active == true()))
4040
.order_by(RequestTypeOption.position)
4141
.subquery())
4242
else:
4343
survey_question = (db.session.query(RequestTypeOption.position.label('position'),
4444
RequestTypeOption.label.label('label'),
45-
RequestTypeOption.request_id)
45+
RequestTypeOption.key)
4646
.filter(and_(RequestTypeOption.survey_id.in_(analytics_survey_id),
4747
RequestTypeOption.is_active == true(),
4848
or_(RequestTypeOption.display == true(),
@@ -52,11 +52,11 @@ def get_survey_result(
5252

5353
# Get all the survey responses with the counts for each response specific to a survey id which
5454
# are in active status.
55-
survey_response = (db.session.query(ResponseTypeOptionModel.request_id, ResponseTypeOptionModel.value,
56-
func.count(ResponseTypeOptionModel.request_id).label('response'))
55+
survey_response = (db.session.query(ResponseTypeOptionModel.request_key, ResponseTypeOptionModel.value,
56+
func.count(ResponseTypeOptionModel.request_key).label('response'))
5757
.filter(and_(ResponseTypeOptionModel.survey_id.in_(analytics_survey_id),
5858
ResponseTypeOptionModel.is_active == true()))
59-
.group_by(ResponseTypeOptionModel.request_id, ResponseTypeOptionModel.value)
59+
.group_by(ResponseTypeOptionModel.request_key, ResponseTypeOptionModel.value)
6060
.subquery())
6161

6262
# Combine the data fetched above such that the result has a format as below
@@ -69,7 +69,7 @@ def get_survey_result(
6969
func.json_agg(func.json_build_object('value', survey_response.c.value,
7070
'count', survey_response.c.response))
7171
.label('result'))
72-
.join(survey_response, survey_response.c.request_id == survey_question.c.request_id)
72+
.join(survey_response, survey_response.c.request_key == survey_question.c.key)
7373
.group_by(survey_question.c.position, survey_question.c.label))
7474

7575
return survey_result.all()

0 commit comments

Comments
 (0)